R4R: GaiaCLI - refactor/fix --account and --index

[jleni]

This PR addresses #3427

There are still some usability concerns that might need to be addressed in another issue (maybe #1480)

• Every time an address is created, a new mnemonic is generated, so hd wallets are not convenient and multiple mnemonics need to be remembered.
• Given a known mnemonic, it is only possible to generate a few derived addresses by using --recover. This might now be intuitive to users.
• It is not possible to generate a set of derived address.i.e. HD wallets from 40'/118'/0'/0/[1..10]

bip44path has been completely removed and all addresses follow the format: 44'/118'/[account]'/0/[index]

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added entries in PENDING.md with issue #

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[jackzampolin]

Some initial comments. This should definately get some more eyes cc @cwgoes @liamsi @ebuchman @alexanderbez @alessio

[jleni]

Tagging with REST as the PR end up affecting REST in multiple places

[jleni]

mm.. test_cover is running tests in parallel and currently lcd_test.go cannot handle that.. :(

It seems it is time to fix this:

cosmos-sdk/client/lcd/test_helpers.go

Lines 208 to 210 in 90797f5

	// TODO: Make InitializeTestLCD safe to call in multiple tests at the same time
	// InitializeTestLCD starts Tendermint and the LCD in process, listening on

[jleni]

Maybe this is not the case, I need to investigate a bit more

[jackzampolin]

This looks G2G to me. Just one minor nit in my comments. Thanks for taking a stab at cleaning this code up @jleni !

[jleni]

This looks G2G to me. Just one minor nit in my comments. Thanks for taking a stab at cleaning this code up @jleni !

Happy to help with this too!

[alessio]

Approved - pending conflicts resolution

[jackzampolin]

@jleni will merge once merge conflicts are fixed!

[jleni]

ok! merged/etc.
It is interesting that this PR never received a test coverage report...
anyway, good to go