Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: CLI support for showing bech32 addresses in Ledger devices #3670

Merged
merged 8 commits into from
Feb 25, 2019
Merged

R4R: CLI support for showing bech32 addresses in Ledger devices #3670

merged 8 commits into from
Feb 25, 2019

Conversation

jleni
Copy link
Member

@jleni jleni commented Feb 18, 2019 •
edited
Loading

This PR closes #3658
It requires unreleased Ledger app Cosmos v1.1.0

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jleni jleni changed the title WIP: CLI support for view bech32 feature in Ledger devices WIP: CLI support for keys show ledger_addr -d feature in Ledger devices Feb 18, 2019
@jleni jleni changed the title WIP: CLI support for keys show ledger_addr -d feature in Ledger devices WIP: CLI support for showing bech32 addresses in Ledger devices Feb 18, 2019
@jleni jleni changed the title WIP: CLI support for showing bech32 addresses in Ledger devices R4R: CLI support for showing bech32 addresses in Ledger devices Feb 18, 2019
@jleni jleni added C:CLI ready-for-review C:Ledger Issues and features related Ledger integration and functionality labels Feb 18, 2019
alexanderbez
alexanderbez suggested changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @jleni -- I left a few minor comments. I'll also want to play with this a bit too prior to merging 👍

PENDING.md Outdated Show resolved Hide resolved
client/keys/show.go Show resolved Hide resolved
client/keys/show.go Show resolved Hide resolved
crypto/ledger_secp256k1.go Outdated Show resolved Hide resolved
@jleni
Copy link
Member Author

jleni commented Feb 18, 2019

Looks good @jleni -- I left a few minor comments. I'll also want to play with this a bit too prior to merging

Yes, definitely! Feedback specific to the app is going to this issue here: cosmos/ledger-cosmos#101

@jleni jleni mentioned this pull request Feb 19, 2019
Closed
@jleni
Copy link
Member Author

jleni commented Feb 19, 2019

All items in the review have been considered or issues have been opened.
@alexanderbez Let me know if you need any help with manual testing.

@jackzampolin
Copy link
Member

@jleni do you mind fixing merge conflicts here? Also lets get this cherrypicked into 0.32.1

@jleni
Copy link
Member Author

jleni commented Feb 25, 2019

Any updates on this?

@jleni jleni mentioned this pull request Feb 25, 2019
Closed
cwgoes
cwgoes approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cwgoes cwgoes merged commit 3eb0acd into cosmos:develop Feb 25, 2019
@jleni jleni mentioned this pull request Feb 28, 2019
Closed
3 tasks
@rllola rllola deleted the jleni/bech32cli branch November 21, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin jackzampolin left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@alessio alessio Awaiting requested review from alessio

Assignees
No one assigned
Labels
C:CLI C:Ledger Issues and features related Ledger integration and functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI support for view bech32 feature in Ledger devices
5 participants
@jleni @jackzampolin @alessio @alexanderbez @cwgoes