Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Minting mechanism explanatory docs #3894

Merged
merged 7 commits into from
Mar 18, 2019
Merged

Conversation

rigelrozanski
Copy link
Contributor

closes #3752

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #3894 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3894      +/-   ##
===========================================
- Coverage    60.95%   60.94%   -0.02%     
===========================================
  Files          192      192              
  Lines        14360    14360              
===========================================
- Hits          8753     8751       -2     
- Misses        5033     5035       +2     
  Partials       574      574

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. Left a few remarks ⚡️

docs/spec/mint/01_concepts.md Outdated Show resolved Hide resolved
docs/spec/mint/01_concepts.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; a few clarification suggestions.

docs/spec/mint/01_concepts.md Outdated Show resolved Hide resolved
docs/spec/mint/01_concepts.md Outdated Show resolved Hide resolved
docs/spec/mint/01_concepts.md Outdated Show resolved Hide resolved
docs/spec/mint/01_concepts.md Outdated Show resolved Hide resolved
docs/spec/mint/01_concepts.md Outdated Show resolved Hide resolved
docs/spec/mint/01_concepts.md Outdated Show resolved Hide resolved
docs/spec/mint/01_concepts.md Outdated Show resolved Hide resolved
Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>
@rigelrozanski
Copy link
Contributor Author

C'est Bizarre! It looks like the CI doesn't run for code merged conducted from Github PR suggestions

@rigelrozanski rigelrozanski merged commit ea9aecd into develop Mar 18, 2019
@rigelrozanski rigelrozanski deleted the rigel/minting-expl-docs branch March 18, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explanatory docs: Minting mechanism
3 participants