x/ibc proto migration #5704
x/ibc proto migration #5704
Conversation
| protoValset, err := tmVals.ToProto() | ||
| if err != nil { | ||
| // TODO: should this return false instead? | ||
| panic(err) | ||
| } |
There was a problem hiding this comment.
self-reminder: address
| @@ -34,6 +35,8 @@ func New() *Codec { | |||
| // codec. | |||
| func RegisterCrypto(cdc *Codec) { | |||
| cryptoamino.RegisterAmino(cdc) | |||
| cryptoamino.RegisterKeyType(protokeys.PrivateKey{}, "tendermint/proto/PrivateKey") | |||
There was a problem hiding this comment.
@marbar3778 I'm getting some errors with the encoding because it doesn't recognize the new priv/pubkey. Can you take a look when you have time?
There was a problem hiding this comment.
you will have to define your own proto type. we decided to only support ed25519 in tendermints proto key types
There was a problem hiding this comment.
created a pr to show how this could be done simply: #5997
if this works i can work on completing that PR
fedekunze
requested review from
alessio,
alexanderbez,
hschoenburg and
nylira
as code owners
| @@ -1,7 +1,7 @@ | |||
| syntax = "proto3"; | |||
| package tendermint.proto.crypto; | |||
| package tendermint.proto.crypto.keys; | |||
There was a problem hiding this comment.
you dont need this file as you will have to define your own proto type
|
Per discussion with @fedekunze this is out-of-date but updating it is blocked on the Tendermint protobuf changes upstream (for ICS 7 client migration to protobuf). |
|
replaced by #6254 |
Description
Switches IBC module from amino to Protobuf encoding
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)