Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: support offline flag in config command #5856

Merged
merged 6 commits into from
Mar 30, 2020
Merged

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Mar 23, 2020

Closes: #5855

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jgimeno jgimeno self-assigned this Mar 23, 2020
@jgimeno jgimeno marked this pull request as ready for review March 23, 2020 20:40
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #5856 into master will increase coverage by 0.03%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master    #5856      +/-   ##
==========================================
+ Coverage   56.78%   56.82%   +0.03%     
==========================================
  Files         342      342              
  Lines       20047    20044       -3     
==========================================
+ Hits        11383    11389       +6     
+ Misses       7815     7805      -10     
- Partials      849      850       +1     

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Please update and test the changes with gaia once this is merged

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unexpected change that needs to be addressed

client/config/config.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all good

@alessio alessio requested a review from tac0turtle March 23, 2020 22:48
@alessio alessio changed the title Add offline flag supported in config. add offline flag supported in config Mar 30, 2020
@alessio alessio changed the title add offline flag supported in config client: support offline flag in config command Mar 30, 2020
@alessio alessio merged commit e5bde01 into master Mar 30, 2020
@alessio alessio deleted the jonathan/offline-config branch March 30, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gaiacli config: support --offline flag
2 participants