-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/keys: move tendermint key types to the SDK #5868
Conversation
…cosmos-sdk into fedekunze/5819-move-keys
This pull request introduces 2 alerts when merging 5e4724d into c36c9f1 - view on LGTM.com new alerts:
|
This PR may need to be broken down by keys. This PR is growing to be quite large and these are important things to get right and should be reviewed in depth. |
I believe all that is needed is to define a proto type and import the tendermint types as the used types when casting. will make the needed changes for this |
this is a simpler approach #5997 let me know if this works |
Replaced by #5997 |
Closes: #5819
Description
Defines
Ed25519
,Secp256k1
,Sr25519
andMultisignature
pubkey and privkeys as proto messages.Dependency migration from Tendermint will come on another PR.
TODO:
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)