Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ModuleAccount to x/auth #6029

Merged
merged 11 commits into from
Apr 20, 2020
Merged

Move ModuleAccount to x/auth #6029

merged 11 commits into from
Apr 20, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 20, 2020 •
edited
Loading

closes: #6027

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez self-assigned this Apr 20, 2020
@alexanderbez alexanderbez marked this pull request as ready for review April 20, 2020 18:22
@alexanderbez alexanderbez added R4R and removed WIP labels Apr 20, 2020
fedekunze
fedekunze approved these changes Apr 20, 2020
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

CHANGELOG.md Outdated Show resolved Hide resolved
@alexanderbez @fedekunze
Update CHANGELOG.md
9da48cd 
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
@alessio alessio added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 20, 2020
@mergify mergify bot merged commit fea2315 into master Apr 20, 2020
@mergify mergify bot deleted the bez/6027-move-mod-accounts branch April 20, 2020 19:32
@denalimarsh denalimarsh mentioned this pull request Jun 8, 2020
Closed
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@alexanderbez @fedekunze
Move ModuleAccount to x/auth (cosmos#6029)
4788b3f 
* Move ModuleAccount to x/auth

* Update x/auth module

* Update x/staking

* Update x/mint

* Update x/gov

* Update x/distribution

* Update simapp

* Update x/bank

* Update std codec

* Add changelog entries

* Update CHANGELOG.md

Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio alessio alessio approved these changes

@fedekunze fedekunze fedekunze approved these changes

@hschoenburg hschoenburg Awaiting requested review from hschoenburg

@nylira nylira Awaiting requested review from nylira

@jgimeno jgimeno Awaiting requested review from jgimeno

@aaronc aaronc Awaiting requested review from aaronc

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees

@alexanderbez alexanderbez

Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth C:x/bank
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Module Account to x/auth
3 participants
@alexanderbez @alessio @fedekunze