Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/ibc: fix int overflow #6171

Merged
merged 1 commit into from
May 8, 2020
Merged

x/ibc: fix int overflow #6171

merged 1 commit into from
May 8, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented May 7, 2020

x/ibc/07-tendermint/types/test_utils.go: Calculate and use
machine-dependent maxInt instead of causing int overflow by
passing math.MaxInt64.

Closes: #6130

This mitigation should be applied while we wait for tendermint
to migrate away from machine-dependent integers.

x/ibc/07-tendermint/types/test_utils.go: Calculate and use
machine-dependent maxInt instead of causing int overflow by
passing math.MaxInt64.

Closes: #6130
@auto-comment
Copy link

auto-comment bot commented May 7, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Thank you for your contribution to the Cosmos-SDK! 🚀

@alessio alessio requested review from tac0turtle and jgimeno May 7, 2020 23:11
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #6171 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #6171   +/-   ##
=======================================
  Coverage   54.79%   54.79%           
=======================================
  Files         443      443           
  Lines       26704    26704           
=======================================
  Hits        14633    14633           
  Misses      11032    11032           
  Partials     1039     1039           

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze fedekunze merged commit c8c4778 into master May 8, 2020
@fedekunze fedekunze deleted the alessio/calculate-maxint branch May 8, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build on 32 bit
2 participants