Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ADR 025 for passive channels #6250

Merged
merged 8 commits into from
Jun 8, 2020
Merged

Conversation

michaelfig
Copy link
Contributor

@michaelfig michaelfig commented May 19, 2020

Description

This ADR is a proposal to enable "passive" IBC relayers (ones that manage a whole connection and detect when channels come and go), as well as an "attempt channel try open" callback to allow an application to decide how and whether to handle inbound channel open handshakes.

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@clevinson
Copy link
Contributor

clevinson commented May 19, 2020

@michaelfig Can you rename this to a nonconflicting ADR number (i think 025 is the lowest available). 023 is already in use here by this WIP ADR: #6083

@michaelfig michaelfig changed the title New ADR 023 for passive channels New ADR 024 for passive channels May 19, 2020
@fedekunze fedekunze added T: ADR An issue or PR relating to an architectural decision record x/ibc labels May 19, 2020
@michaelfig michaelfig changed the title New ADR 024 for passive channels New ADR 025 for passive channels May 19, 2020
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michaelfig. Concept ACK. It'd be great to have a bit more context by adding a few examples to ease the implementation process. 👍

docs/architecture/adr-024-ibc-passive-channels.md Outdated Show resolved Hide resolved
docs/architecture/adr-024-ibc-passive-channels.md Outdated Show resolved Hide resolved
docs/architecture/adr-024-ibc-passive-channels.md Outdated Show resolved Hide resolved
docs/architecture/adr-024-ibc-passive-channels.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is much clearer now, still a few questions on defaults and motivation.

docs/architecture/adr-025-ibc-passive-channels.md Outdated Show resolved Hide resolved
docs/architecture/adr-025-ibc-passive-channels.md Outdated Show resolved Hide resolved
docs/architecture/adr-025-ibc-passive-channels.md Outdated Show resolved Hide resolved
docs/architecture/adr-025-ibc-passive-channels.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, but let's change to a default implementation instead of a alternative call path

docs/architecture/adr-025-ibc-passive-channels.md Outdated Show resolved Hide resolved
@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 1, 2020
@tac0turtle
Copy link
Member

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2020

Command refresh: success

@tac0turtle
Copy link
Member

@michaelfig could you update to master or allow modifications

@michaelfig
Copy link
Contributor Author

@michaelfig could you update to master or allow modifications

Updated to master. I don't know where to allow modifications, though.

@tac0turtle
Copy link
Member

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2020

Command refresh: success

@tac0turtle
Copy link
Member

Updated to master. I don't know where to allow modifications, though.

seems like you need to update to master again. here is how you can allow modifications https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork and then we dont have to keep pinging you to update the pr

@michaelfig
Copy link
Contributor Author

michaelfig commented Jun 8, 2020

@Mergifyio refresh

FWIW, since I don't know if I'm allowed to tell the bot that. Guess I'm not.

seems like you need to update to master again.

Updated.

here is how you can allow modifications ... and then we dont have to keep pinging you to update the pr

I created this PR from an organization (agoric-labs) instead of my user account (michaelfig), so this option is not presented to me. Unfortunate, but apparently Github does not support that configuration... I guess they don't imagine orgs contributing to other orgs.

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2020

@michaelfig is not allowed to run commands

@fedekunze fedekunze merged commit cd94032 into cosmos:master Jun 8, 2020
@michaelfig michaelfig deleted the ibc-passive branch June 14, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: ADR An issue or PR relating to an architectural decision record
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants