Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic x/bank gRPC query service #6343

Merged
merged 12 commits into from
Jun 5, 2020
Merged

Add basic x/bank gRPC query service #6343

merged 12 commits into from
Jun 5, 2020

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jun 4, 2020

ref: #5921

This adds a basic gRPC Query service for x/bank implemented on the keeper.

It does not handle pagination (#6191), grpc-gateway REST mappings, or update the query CLI cmd's - those are to be added in future PRs,


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@aaronc aaronc changed the title Add basic x/bank gRPC query server Add basic x/bank gRPC query service Jun 4, 2020
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #6343 into master will increase coverage by 0.02%.
The diff coverage is 78.37%.

@@            Coverage Diff             @@
##           master    #6343      +/-   ##
==========================================
+ Coverage   55.70%   55.72%   +0.02%     
==========================================
  Files         449      450       +1     
  Lines       27006    27036      +30     
==========================================
+ Hits        15043    15067      +24     
- Misses      10883    10886       +3     
- Partials     1080     1083       +3     

@aaronc aaronc marked this pull request as ready for review June 5, 2020 00:23
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aaronc aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 5, 2020
@mergify mergify bot merged commit 72925fa into master Jun 5, 2020
@mergify mergify bot deleted the aaronc/5921-grpc-x-bank branch June 5, 2020 18:10
@aaronc aaronc mentioned this pull request Jun 10, 2020
11 tasks
@clevinson clevinson added this to the v0.39 milestone Jun 11, 2020
@aaronc aaronc mentioned this pull request Jul 1, 2020
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/bank
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants