-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/bank: remove alias.go usage #6439
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6439 +/- ##
=======================================
Coverage 55.72% 55.72%
=======================================
Files 465 465
Lines 27782 27782
=======================================
Hits 15481 15481
Misses 11197 11197
Partials 1104 1104 |
@@ -20,6 +20,8 @@ import ( | |||
"github.com/cosmos/cosmos-sdk/x/auth" | |||
"github.com/cosmos/cosmos-sdk/x/auth/ante" | |||
"github.com/cosmos/cosmos-sdk/x/bank" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this import here still?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
The integration tests are failing. The strange things is, if I checkout the latest commit of the master branch (commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
that is interesting. I haven't looked at the integration tests, will try to see whats happening
* x/bank: remove alias.go usage * Fix simd_test.go
Description
This PR closes a sub task in #6311
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer