Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mint: gRPC query service #6535

Merged
merged 19 commits into from
Jul 7, 2020
Merged

x/mint: gRPC query service #6535

merged 19 commits into from
Jul 7, 2020

Conversation

atheeshp
Copy link
Contributor

Description

ref: #5921

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #6535 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6535      +/-   ##
==========================================
+ Coverage   57.72%   57.74%   +0.02%     
==========================================
  Files         494      495       +1     
  Lines       29644    29656      +12     
==========================================
+ Hits        17111    17125      +14     
+ Misses      11301    11300       -1     
+ Partials     1232     1231       -1     

@aaronc aaronc mentioned this pull request Jun 30, 2020
43 tasks
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It'd be nice if we could use the existing testing suite for the setup

x/mint/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍, just some docs update

proto/cosmos/mint/query.proto Outdated Show resolved Hide resolved
proto/cosmos/mint/query.proto Outdated Show resolved Hide resolved
proto/cosmos/mint/query.proto Outdated Show resolved Hide resolved
proto/cosmos/mint/query.proto Outdated Show resolved Hide resolved
@alexanderbez alexanderbez removed the R4R label Jul 7, 2020
x/mint/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 7, 2020
@mergify mergify bot merged commit 58dcef1 into master Jul 7, 2020
@mergify mergify bot deleted the atheesh/5921-grpc-x-mint branch July 7, 2020 07:33
@clevinson clevinson added this to the v0.40 [Stargate] milestone Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/mint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants