Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert x/auth query CLI commands to use gRPC query client #6643

Conversation

akhilkumarpilli
Copy link
Contributor

Description

ref: #5921

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #6643 into master will increase coverage by 2.13%.
The diff coverage is 61.92%.

@@            Coverage Diff             @@
##           master    #6643      +/-   ##
==========================================
+ Coverage   55.60%   57.73%   +2.13%     
==========================================
  Files         457      498      +41     
  Lines       27440    29797    +2357     
==========================================
+ Hits        15257    17204    +1947     
- Misses      11083    11350     +267     
- Partials     1100     1243     +143     

@@ -24,7 +25,7 @@ const (
)

// GetQueryCmd returns the transaction commands for this module
func GetQueryCmd(cdc *codec.Codec) *cobra.Command {
func GetQueryCmd(clientCtx client.Context) *cobra.Command {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an FYI, this will all be undone once #6573 is merged. I'm not sure about the order of preference here, but just keep that in mind.

Essentially, command constructors will take no arguments anymore (at least not client.Context). They will instead use a clientCtx := client.GetClientContextFromCmd(cmd) call.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we can wait until #6573 is merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexanderbez Just to get this right: assuming we remove the client.Context arg here and use clientCtx := client.GetClientContextFromCmd(cmd), we can still merge this PR before #6573, correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests pass, yes 👍

@amaury1093 amaury1093 self-assigned this Jul 9, 2020
@aaronc aaronc mentioned this pull request Jul 9, 2020
43 tasks
@clevinson clevinson added this to the v0.40 [Stargate] milestone Jul 9, 2020
@anilcse
Copy link
Collaborator

anilcse commented Jul 21, 2020

Thanks @akhilkumarpilli, Closing this in favour of #6809

@anilcse anilcse closed this Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants