Add pagination flags to x{ibc, bank} #6804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6804 +/- ##
==========================================
+ Coverage 60.43% 62.68% +2.25%
==========================================
Files 514 269 -245
Lines 31635 17935 -13700
==========================================
- Hits 19119 11243 -7876
+ Misses 11049 5897 -5152
+ Partials 1467 795 -672 |
|
lgtm 👍. Would it make sense to remove every instance of FlagPage in this PR? (ref: #6728 (comment)) |
…mos-sdk into atheesh/5921-pagintaion-flags
atheeshp
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
fedekunze
approved these changes
Jul 21, 2020
amaury1093
approved these changes
Jul 21, 2020
There was a problem hiding this comment.
lgtm 👍. Would it make sense to remove every instance of FlagPage in this PR? (ref: #6728 (comment))
ah no, auth's migration to grpc is still in progress, so auth still uses FlagPage.
so good to merge!
fedekunze
added
the
A:automerge
FlagPage is being used in ibc/02-client, x/gov and a client/rpc is also. |
chengwenxi
pushed a commit
to irisnet/cosmos-sdk
that referenced
this pull request
Jul 22, 2020
* updated pagination flags * updated all balances pagination flags * updated all balances * some doc updates Co-authored-by: Anil Kumar Kammari <anil@vitwit.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #5921
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes