Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs & Cleanup #6806

Merged
merged 4 commits into from
Jul 21, 2020
Merged

Docs & Cleanup #6806

merged 4 commits into from
Jul 21, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jul 21, 2020 •
edited
Loading

Description

  • Cleanup old TODO's
  • Remove dead code
  • Add README's & pkg documentation

ref: #6779

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alexanderbez alexanderbez added T:Docs Changes and features related to documentation. Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. A:automerge Automatically merge PR once all prerequisites pass. labels Jul 21, 2020
@alexanderbez alexanderbez marked this pull request as ready for review July 21, 2020 15:21
@alexanderbez alexanderbez merged commit 61d69a9 into master Jul 21, 2020
@alexanderbez alexanderbez deleted the bez/code-cleanup branch July 21, 2020 15:28
chengwenxi pushed a commit to irisnet/cosmos-sdk that referenced this pull request Jul 22, 2020
@alexanderbez @chengwenxi
Merge PR cosmos#6806: Docs & Cleanup
1107e37
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@alexanderbez
Merge PR cosmos#6806: Docs & Cleanup
4db2578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@clevinson clevinson Awaiting requested review from clevinson

@jgimeno jgimeno Awaiting requested review from jgimeno

@sahith-narahari sahith-narahari Awaiting requested review from sahith-narahari

@amaury1093 amaury1093 Awaiting requested review from amaury1093

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation. Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderbez @fedekunze