Fix the one remaining proto tx bug and flip the switch #6902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6902 +/- ##
==========================================
+ Coverage 61.26% 61.42% +0.16%
==========================================
Files 421 517 +96
Lines 25613 32060 +6447
==========================================
+ Hits 15691 19694 +4003
- Misses 8579 10799 +2220
- Partials 1343 1567 +224 |
| @@ -188,9 +188,9 @@ jobs: | |||
| with: | |||
| file: ./coverage.txt | |||
| if: "env.GIT_DIFF != ''" | |||
| test-unit-proto-expected-to-fail: | |||
| test-unit-amino-might-fail: | |||
aaronc
requested review from
alessio,
clevinson,
fedekunze and
jgimeno
as code owners
|
Does this enable SIGN_MODE_DIRECT or "just" the protobuf encoding of the binary transaction (not signbytes)? |
|
alexanderbez
approved these changes
Jul 30, 2020
aaronc
added
A:automerge
sahith-narahari
approved these changes
Jul 30, 2020
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* Fix the one remaining proto tx bug and flip the switch * Update github CI * Wrap TxDecoder errors * Add test * Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #6213
The one remaining bug was an unregistered interface type. The
TxDecodererrors are now wrapped for easier debugging.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes