Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog on master (from v0.40.x branch) #7528

Merged
merged 4 commits into from
Oct 14, 2020

Conversation

clevinson
Copy link
Contributor

@clevinson clevinson commented Oct 13, 2020

Description

Pulls in updated & cleaned-up changelog from v0.40.x branch into master.

Rendered preview


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do this now and not when we officially release v0.40.0?

@clevinson
Copy link
Contributor Author

clevinson commented Oct 14, 2020

I think this would be useful to have rc-level changelog sections for more granular visibility of what subsequent bugfixes / additions get made in each release candidate.

This is me following the process that I saw tendermint using for their v0.34 release process.

My intention would be to squash the rc CHANGELOG sections into a single section for v0.40.0 once we publish the release. In the meantime, this is just meant to add better readability for folks tracking the RC process, who likely want to know which bugfixes make it into each RC.

* (modules) [\#6311](https://github.com/cosmos/cosmos-sdk/issues/6311) Remove `alias.go` usage
* (x/auth) [\#6443](https://github.com/cosmos/cosmos-sdk/issues/6443) Move `FeeTx` and `TxWithMemo` interfaces from `x/auth/ante` to `types`.
* (modules) [\#6447](https://github.com/cosmos/cosmos-sdk/issues/6447) Rename `blacklistedAddrs` to `blockedAddrs`.
* (kvstore) [\#7415](https://github.com/cosmos/cosmos-sdk/pull/7415) Allow new stores to be registered during on-chain upgrades.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be included on v0.40?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a bug fix that would be good to put into 0.40. I added a backport label to it, it'll be included in the next round of backports.

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 14, 2020
@mergify mergify bot merged commit 080fcf1 into master Oct 14, 2020
@mergify mergify bot deleted the clevinson/update-master-changelog branch October 14, 2020 08:55
@alexanderbez
Copy link
Contributor

My intention would be to squash the rc CHANGELOG sections into a single section for v0.40.0 once we publish the release. In the meantime, this is just meant to add better readability for folks tracking the RC process, who likely want to know which bugfixes make it into each RC.

Sure, as long as you tidy it once the release is made I think that's fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants