Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update master docs #8353

Merged
merged 11 commits into from
Feb 23, 2021
Merged

docs: update master docs #8353

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d927d73
bump docs theme to 1.0.180
lovincyrus Jan 15, 2021
a189ff6
add v0.40 to config.js versions
lovincyrus Jan 15, 2021
3411b80
Merge branch 'master' into cyrus/master-docs
okwme Jan 17, 2021
26bb55a
resolve conflicts
lovincyrus Jan 21, 2021
dc51027
Merge branch 'master' into cyrus/master-docs
lovincyrus Jan 22, 2021
f91c549
Fix code snippet link
amaury1093 Jan 26, 2021
8537107
Merge branch 'master' into cyrus/master-docs
lovincyrus Jan 26, 2021
e98f849
Merge branch 'master' into cyrus/master-docs
okwme Feb 6, 2021
b0423d6
Merge branch 'master' into cyrus/master-docs
lovincyrus Feb 22, 2021
9989bea
reorganize order of versions
lovincyrus Feb 22, 2021
df9f27e
Merge branch 'master' into cyrus/master-docs
mergify[bot] Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/.vuepress/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ module.exports = {
index: "cosmos-sdk"
},
versions: [
{
"label": "v0.40",
"key": "v0.40"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the v0.40 has been kind of yanked, should we just show v0.39, v0.41 and master?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we don't plan on using v0.40, then we shouldn't include it in the version dropdown. Can you confirm that? @amaurymartiny

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about this. A recent bugfix (#8461) makes 0.40.* and 0.41.* buggy for ALL chains except gaia. Maybe in the docs we should just skip 0.40 and 0.41 altogether? And show 0.42 directly?

cc @clevinson

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or actually, for 0.41, it would be ideal to show a banner on top of the page saying "if you're not using the hub, please upgrade to 0.42". wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i like this approach. Let's only show docs for v0.41 and v0.42, and have v0.41 clearly point out that there is an evidence bug on v0.41.x that renders chains unstable on v0.41.x if they have a non-default bech32 prefix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lovincyrus can we update this accordingly & merge? This should also include then an update to the versions file, as we now have a release/v0.41.x branch, and most stargate docs updates will only be be backported to there.

Copy link
Contributor Author

@lovincyrus lovincyrus Feb 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only show docs for v0.41 and v0.42

Are we only showing v0.41 and v0.42 and get rid of v0.39 and master from the version dropdown?

nvm, just saw this #8353 (review)

},
amaury1093 marked this conversation as resolved.
Show resolved Hide resolved
{
"label": "v0.39",
"key": "v0.39"
Expand Down
2 changes: 1 addition & 1 deletion docs/core/cli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ This `queryCmd` function adds all the queries available to end-users for the app

Here is an example of a `queryCmd` aggregating subcommands from the `simapp` application:

+++ https://github.com/cosmos/cosmos-sdk/blob/0.40.0/simapp/simd/cmd/root.go#L99-L121
+++ https://github.com/cosmos/cosmos-sdk/blob/v0.40.0/simapp/simd/cmd/root.go#L99-L121

## Flags

Expand Down
216 changes: 108 additions & 108 deletions docs/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.