Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: race detection must not hide errors #8924

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 18, 2021


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

it should fail now right?

@alessio
Copy link
Contributor Author

alessio commented Mar 18, 2021

no, there are no .go files changes

@alessio alessio merged commit 641b13e into master Mar 18, 2021
@alessio alessio deleted the alessio/make-sure-ci-fails branch March 18, 2021 11:30
@alessio alessio changed the title ci: test detection must not hide errors ci: race detection must not hide errors Mar 19, 2021
alessio pushed a commit that referenced this pull request Mar 19, 2021
alessio pushed a commit that referenced this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants