Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v043 audit changes for types/ #9290

Merged
merged 3 commits into from
May 17, 2021
Merged

v043 audit changes for types/ #9290

merged 3 commits into from
May 17, 2021

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented May 10, 2021

Description

ref: #9218. Nothing much came up during the audit.

scope:

  • types/**/*
  • proto/cosmos/base/**/*
  • proto/cosmos/tx/**/*

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@github-actions github-actions bot added the T:Docs Changes and features related to documentation. label May 10, 2021
@amaury1093 amaury1093 marked this pull request as ready for review May 12, 2021 09:39
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #9290 (bf69ea0) into master (a04adf2) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head bf69ea0 differs from pull request most recent head 23e379f. Consider uploading reports for the commit 23e379f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9290      +/-   ##
==========================================
- Coverage   60.39%   60.32%   -0.07%     
==========================================
  Files         587      591       +4     
  Lines       36914    36936      +22     
==========================================
- Hits        22294    22282      -12     
- Misses      12645    12683      +38     
+ Partials     1975     1971       -4     
Impacted Files Coverage Δ
types/address.go 64.75% <ø> (ø)
types/address/hash.go 100.00% <ø> (ø)
types/query/pagination.go 80.00% <ø> (ø)
x/authz/simulation/genesis.go 81.81% <0.00%> (-9.10%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 73.91% <0.00%> (-8.70%) ⬇️
crypto/keys/secp256r1/pubkey.go 76.92% <0.00%> (-3.08%) ⬇️
crypto/keys/secp256r1/privkey.go 80.00% <0.00%> (-2.36%) ⬇️
x/bank/simulation/operations.go 80.64% <0.00%> (-0.76%) ⬇️
simapp/simd/cmd/root.go 62.30% <0.00%> (-0.58%) ⬇️
server/rosetta.go 0.00% <0.00%> (ø)
... and 26 more

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label May 17, 2021
@mergify mergify bot merged commit 321aed8 into master May 17, 2021
@mergify mergify bot deleted the am/9218-audit-types branch May 17, 2021 12:57
roysc pushed a commit to vulcanize/cosmos-sdk that referenced this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants