Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding required chain id opt to baseapp #3296

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Mar 14, 2023

Description

Fixes unit tests in #3295. E2E are still failing, looks like the baseapp opt SetChainID is now required.
see: cosmos/cosmos-sdk#15377

cc. @julienrbrt

Commit Message / Changelog Entry

testing(api!): adding chain id to `SetupTestingApp` as required by baseapp setup opts

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@julienrbrt
Copy link
Member

Yes correct this is now required. Something you do need to update in tests. When using the default baseapp options form the SDK in an app this is added for you.

@crodriguezvega
Copy link
Contributor

Thanks, @damiannolan for opening this PR. I am also fixing the tests in the bump branch, so I will merge this already now.

@crodriguezvega crodriguezvega merged commit 1d977a7 into carlos/bump-sdk-v0.47 Mar 14, 2023
@crodriguezvega crodriguezvega deleted the damian/fix-baseapp-chain-id branch March 14, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants