Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump cosmos-sdk #4615

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Sep 10, 2023

Description

This PR updates cosmos-sdk to the latest commit of v0.50.x

Commit Message / Changelog Entry

deps: bump cosmos-sdk

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - but I think maybe we should wait for a tag

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, but also agree, would prefer to wait for a tag, we could PR every commit here but feels inefficient

@chatton
Copy link
Contributor

chatton commented Sep 11, 2023

We actually need to bump to a commit that includes these changes, the upgrade from v7 -> v8 is failing due to this issue.

@colin-axner
Copy link
Contributor

pulled in the latest sdk commit https://github.com/cosmos/cosmos-sdk/commits/release/v0.50.x

@codecov-commenter
Copy link

Codecov Report

Merging #4615 (6221576) into main (b53bfa5) will increase coverage by 0.04%.
Report is 11 commits behind head on main.
The diff coverage is 94.44%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4615      +/-   ##
==========================================
+ Coverage   79.28%   79.32%   +0.04%     
==========================================
  Files         188      188              
  Lines       13053    13088      +35     
==========================================
+ Hits        10349    10382      +33     
- Misses       2270     2271       +1     
- Partials      434      435       +1     
Files Changed Coverage Δ
modules/apps/transfer/module.go 46.55% <33.33%> (-1.67%) ⬇️
modules/apps/transfer/keeper/genesis.go 92.59% <100.00%> (+0.28%) ⬆️
modules/apps/transfer/keeper/keeper.go 91.83% <100.00%> (+1.21%) ⬆️
modules/apps/transfer/keeper/migrations.go 96.87% <100.00%> (+0.57%) ⬆️
modules/apps/transfer/keeper/relay.go 91.00% <100.00%> (+0.09%) ⬆️

@crodriguezvega crodriguezvega merged commit 70a0f76 into cosmos:main Sep 13, 2023
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants