Fix run-e2e.sh #4624
Merged
Fix run-e2e.sh #4624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan and
DimitrisJim
as code owners
damiannolan
approved these changes
Sep 11, 2023
colin-axner
approved these changes
Sep 11, 2023
|
Looks like runners don't have |
|
@damiannolan script works as intended so 👯 |
…-jq-or-fzf-are-not-installed
…-jq-or-fzf-are-not-installed
…-jq-or-fzf-are-not-installed
|
@colin-axner turns out the runners didn't have fzf :D, updated the script, let me know if you're okay with the changes |
chatton
deleted the
cian/issue#4600-e2e-returns-blank-error-when-jq-or-fzf-are-not-installed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #4600
Quick fix for the e2e script. The existing logic had good intentions but did work 😓
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.