Update ADR8 #4631
Merged
Update ADR8 #4631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaSripal
requested review from
colin-axner,
crodriguezvega,
charleenfei,
damiannolan,
chatton,
DimitrisJim and
srdtrk
as code owners
AdityaSripal
commented
Sep 12, 2023
Comment on lines
237
to
241
| The callback will then be routed through the callback keeper which will either panic or return a result (success or failure). In the event of a panic or an error, the callback state changes | ||
| are discarded and the transaction is committed. | ||
|
|
||
| If the transaction runs out of gas because the relayer-defined limit was exceeded the entire transaction is reverted to allow for resubmission. If the chain-defined or user-defined gas limit is reached, | ||
| the callback state changes are reverted and the transaction is committed. |
There was a problem hiding this comment.
The panic/revert/commit behavior is the part I need double checked specifically. @srdtrk
srdtrk
added
docs
srdtrk
reviewed
Sep 13, 2023
There was a problem hiding this comment.
Thank you @AdityaSripal, left some questions and suggestions.
Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
srdtrk
approved these changes
Sep 18, 2023
Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
damiannolan
approved these changes
Sep 19, 2023
DimitrisJim
approved these changes
Sep 19, 2023
Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
* update adr8 to latest implementation decisions * fix link * fixed relationship between CallbackPacketData and packet data interfaces * update changelog * Apply suggestions from code review Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> * fix(docs): fix broken link * address rest of comments * Update docs/architecture/adr-008-app-caller-cbs.md Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> --------- Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: srdtrk <srdtrk@hotmail.com> Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> (cherry picked from commit 68f7ab3) # Conflicts: # docs/architecture/README.md
DimitrisJim
pushed a commit
that referenced
this pull request
Sep 20, 2023
* docs: update ADR8 (#4631) * update adr8 to latest implementation decisions * fix link * fixed relationship between CallbackPacketData and packet data interfaces * update changelog * Apply suggestions from code review Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> * fix(docs): fix broken link * address rest of comments * Update docs/architecture/adr-008-app-caller-cbs.md Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> --------- Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: srdtrk <srdtrk@hotmail.com> Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> (cherry picked from commit 68f7ab3) # Conflicts: # docs/architecture/README.md * Update README.md --------- Co-authored-by: Aditya <adityasripal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.