e2e: use interchaintest main #4662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal,
charleenfei,
damiannolan,
chatton and
DimitrisJim
as code owners
damiannolan
approved these changes
Sep 14, 2023
|
e2e build is failing actually, looks like something to do with the |
|
hmm... Seems like something else broke... I will take a look later. |
|
It was removed in strangelove-ventures/interchaintest#759 and looks like its determined internally now |
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
crodriguezvega
commented
Sep 18, 2023
| // this may need to be updated if log entries are inserted in between exporting of state and the server module logging | ||
| // see issue: https://github.com/strangelove-ventures/interchaintest/issues/721 | ||
| str := strings.SplitAfter(state, "server") | ||
| state = str[1] |
There was a problem hiding this comment.
The issue referenced here has been closed.
DimitrisJim
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should get us out of @colin-axner's fork.
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.