feat: add empty address check on authority field #4713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
AdityaSripal and
damiannolan
as code owners
colin-axner
requested review from
crodriguezvega,
chatton,
charleenfei and
DimitrisJim
damiannolan
approved these changes
Sep 19, 2023
DimitrisJim
approved these changes
Sep 19, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4713 +/- ##
==========================================
+ Coverage 79.65% 79.70% +0.04%
==========================================
Files 187 187
Lines 13195 13203 +8
==========================================
+ Hits 10511 10523 +12
+ Misses 2253 2251 -2
+ Partials 431 429 -2
|
charleenfei
approved these changes
Sep 19, 2023
| @@ -52,6 +52,10 @@ func NewKeeper( | |||
| legacySubspace = legacySubspace.WithKeyTable(types.ParamKeyTable()) | |||
| } | |||
|
|
|||
| if strings.TrimSpace(authority) == "" { | |||
| panic(fmt.Errorf("authority must be non-empty")) | |||
There was a problem hiding this comment.
Was it really needed to use Errorf, since the string does not require formatting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #4667
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.