Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fzf selection for config files #4725

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Sep 20, 2023

Description

When debugging many tests with different configurations (e.g. compatibility tests) it can be a hassle switching between lots of different config files. This PR makes that a bit easier by adding fzf support to interactively choose which config file you want to use for a test.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@chatton chatton added type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. e2e labels Sep 20, 2023
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye! Nice one!

@chatton chatton merged commit 3120335 into main Sep 20, 2023
57 of 58 checks passed
@chatton chatton deleted the cian/dynamically-select-test-config branch September 20, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants