E2E To verify legacy client upgrade proposal fails #4748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal,
damiannolan,
crodriguezvega,
charleenfei and
DimitrisJim
as code owners
…ter-msg-ibc-software-upgrade
…ter-msg-ibc-software-upgrade
…ter-msg-ibc-software-upgrade
damiannolan
approved these changes
Sep 25, 2023
…ter-msg-ibc-software-upgrade
9 tasks
DimitrisJim
approved these changes
Sep 25, 2023
chatton
deleted the
cian/verify-client-upgrade-proposal-fails-after-msg-ibc-software-upgrade
branch
colin-axner
reviewed
Sep 25, 2023
| @@ -209,6 +203,17 @@ func (s *E2ETestSuite) ExecuteGovV1Beta1Proposal(ctx context.Context, chain *cos | |||
| s.Require().Equal(govtypesv1beta1.StatusPassed, proposal.Status) | |||
| } | |||
|
|
|||
| // ExecuteGovV1Beta1Proposal submits a v1beta1 governance proposal using the provided content. | |||
| func (s *E2ETestSuite) ExecuteGovV1Beta1Proposal(ctx context.Context, chain *cosmos.CosmosChain, user ibc.Wallet, content govtypesv1beta1.Content) sdk.TxResponse { | |||
There was a problem hiding this comment.
food for thought nit: executing governance proposals to me kinda assumes they passed as I'm imaging the proposal being executed. This is just submitting the proposal, nothing is being executed, but I don't feel strongly about this. Just mentioning it since it came to mind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #4721
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.