e2e: timeout transfer with grandpa light client #5018
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -73,6 +73,7 @@ type GrandpaTestSuite struct { | |
| // * send transfer over ibc | ||
| func (s *GrandpaTestSuite) TestMsgTransfer_Succeeds_GrandpaContract() { | ||
| ctx := context.Background() | ||
| t := s.T() | ||
|
|
||
| chainA, chainB := s.GetGrandpaTestChains() | ||
|
|
||
|
|
@@ -109,6 +110,15 @@ func (s *GrandpaTestSuite) TestMsgTransfer_Succeeds_GrandpaContract() { | |
| fundAmount := int64(12_333_000_000_000) | ||
| polkadotUser, cosmosUser := s.fundUsers(ctx, fundAmount, polkadotChain, cosmosChain) | ||
|
|
||
| // TODO: this can be refactored to broadcast a MsgTransfer instead of CLI. | ||
| // https://github.com/cosmos/ibc-go/issues/4963 | ||
| amountToSend := int64(1_770_000) | ||
| transfer := ibc.WalletAmount{ | ||
| Address: polkadotUser.FormattedAddress(), | ||
| Denom: cosmosChain.Config().Denom, | ||
| Amount: math.NewInt(amountToSend), | ||
| } | ||
|
|
||
| pathName := s.GetPathName(0) | ||
|
|
||
| err = r.GeneratePath(ctx, eRep, cosmosChain.Config().ChainID, polkadotChain.Config().ChainID, pathName) | ||
|
|
@@ -135,79 +145,110 @@ func (s *GrandpaTestSuite) TestMsgTransfer_Succeeds_GrandpaContract() { | |
| // Start relayer | ||
| s.Require().NoError(r.StartRelayer(ctx, eRep, pathName)) | ||
|
|
||
| t.Run("IBC transfer from Cosmos chain to Polkadot parachain times out", func(t *testing.T) { | ||
|
There was a problem hiding this comment. did we want to add this as a completely separate test? Right now this is being added to TestMsgTransfer_Succeeds_GrandpaContract, right? This is maybe a little misleading. What do you think? There was a problem hiding this comment. I did it as part of this test bc the setup takes so long for these tests (due to gov proposal needed to create a wasm client, etc). If you think it's worth it to add as a completely separate test I can do it, but tbh I really don't know if it's worth the setup time, as the functionality can easily be tested in the transfer flow. I could update the test name for clarity, as another option. There was a problem hiding this comment. I agree with you that the test setup is pretty long winded and takes up quite a bit of time. But I think it would just be at the expense of one extra runner, right? General separation of concerns would have me leaning towards a separate test, even tho there's also probably some code duplication. I'd be fine with leaving it in this one too if there's consensus, but maybe we could rename the test if that were the case. Any thoughts? cc. @chatton @DimitrisJim @srdtrk There was a problem hiding this comment. I'd lean towards a separate test too, in most cases these tests will be running side by side anyway, so the time difference shouldn't be noticeable. There was a problem hiding this comment. I'd prefer a separate but I'd be fine if done in separate PR so Charly can get that long awaited satisfaction from finally merging this son of a gun There was a problem hiding this comment. alright! i can make a separate test, no worries. I'd rather do it now than revisit later haha, close it up and zip it up. |
||
| // Stop relayer | ||
| s.Require().NoError(r.StopRelayer(ctx, s.GetRelayerExecReporter())) | ||
|
|
||
| tx, err := cosmosChain.SendIBCTransfer(ctx, "channel-0", cosmosUser.KeyName(), transfer, ibc.TransferOptions{Timeout: testvalues.ImmediatelyTimeout()}) | ||
| s.Require().NoError(err) | ||
| s.Require().NoError(tx.Validate(), "source ibc transfer tx is invalid") | ||
| time.Sleep(time.Nanosecond * 1) // want it to timeout immediately | ||
|
|
||
| // check that tokens are escrowed | ||
| actualBalance, err := cosmosChain.GetBalance(ctx, cosmosUser.FormattedAddress(), cosmosChain.Config().Denom) | ||
| s.Require().NoError(err) | ||
| expected := fundAmount - amountToSend | ||
| s.Require().Equal(expected, actualBalance.Int64()) | ||
|
|
||
| // start relayer | ||
| s.Require().NoError(r.StartRelayer(ctx, s.GetRelayerExecReporter(), s.GetPathName(0))) | ||
| err = testutil.WaitForBlocks(ctx, 15, polkadotChain, cosmosChain) | ||
| s.Require().NoError(err) | ||
|
|
||
| // ensure that receiver on parachain did not receive any tokens | ||
| receiverBalance, err := polkadotChain.GetIbcBalance(ctx, polkadotUser.FormattedAddress(), 2) | ||
| s.Require().NoError(err) | ||
| s.Require().Equal(int64(0), receiverBalance.Amount.Int64()) | ||
|
|
||
| // check that tokens have been refunded to sender address | ||
| senderBalance, err := cosmosChain.GetBalance(ctx, cosmosUser.FormattedAddress(), cosmosChain.Config().Denom) | ||
| s.Require().NoError(err) | ||
| s.Require().Equal(fundAmount, senderBalance.Int64()) | ||
| }) | ||
|
|
||
| t.Run("send successful IBC transfer from Cosmos to Polkadot parachain", func(t *testing.T) { | ||
| // Send 1.77 stake from cosmosUser to parachainUser | ||
| tx, err := cosmosChain.SendIBCTransfer(ctx, "channel-0", cosmosUser.KeyName(), transfer, ibc.TransferOptions{}) | ||
| s.Require().NoError(tx.Validate(), "source ibc transfer tx is invalid") | ||
| s.Require().NoError(err) | ||
| // verify token balance for cosmos user has decreased | ||
| balance, err := cosmosChain.GetBalance(ctx, cosmosUser.FormattedAddress(), cosmosChain.Config().Denom) | ||
| s.Require().NoError(err) | ||
| s.Require().Equal(balance, math.NewInt(fundAmount-amountToSend), "unexpected cosmos user balance after first tx") | ||
| err = testutil.WaitForBlocks(ctx, 15, cosmosChain, polkadotChain) | ||
| s.Require().NoError(err) | ||
|
|
||
| // Verify tokens arrived on parachain user | ||
| parachainUserStake, err := polkadotChain.GetIbcBalance(ctx, string(polkadotUser.Address()), 2) | ||
| s.Require().NoError(err) | ||
| s.Require().Equal(amountToSend, parachainUserStake.Amount.Int64(), "unexpected parachain user balance after first tx") | ||
| }) | ||
|
|
||
| t.Run("send two successful IBC transfers from Polkadot parachain to Cosmos, first with ibc denom, second with parachain denom", func(t *testing.T) { | ||
| // Send 1.16 stake from parachainUser to cosmosUser | ||
| amountToReflect := int64(1_160_000) | ||
| reflectTransfer := ibc.WalletAmount{ | ||
| Address: cosmosUser.FormattedAddress(), | ||
| Denom: "2", // stake | ||
| Amount: math.NewInt(amountToReflect), | ||
| } | ||
| _, err := polkadotChain.SendIBCTransfer(ctx, "channel-0", polkadotUser.KeyName(), reflectTransfer, ibc.TransferOptions{}) | ||
| s.Require().NoError(err) | ||
|
|
||
| // Send 1.88 "UNIT" from Alice to cosmosUser | ||
| amountUnits := math.NewInt(1_880_000_000_000) | ||
| unitTransfer := ibc.WalletAmount{ | ||
| Address: cosmosUser.FormattedAddress(), | ||
| Denom: "1", // UNIT | ||
| Amount: amountUnits, | ||
| } | ||
| _, err = polkadotChain.SendIBCTransfer(ctx, "channel-0", "alice", unitTransfer, ibc.TransferOptions{}) | ||
| s.Require().NoError(err) | ||
|
|
||
| // Wait for MsgRecvPacket on cosmos chain | ||
| finalStakeBal := math.NewInt(fundAmount - amountToSend + amountToReflect) | ||
| err = cosmos.PollForBalance(ctx, cosmosChain, 20, ibc.WalletAmount{ | ||
| Address: cosmosUser.FormattedAddress(), | ||
| Denom: cosmosChain.Config().Denom, | ||
| Amount: finalStakeBal, | ||
| }) | ||
| s.Require().NoError(err) | ||
|
|
||
| // Wait for a new update state | ||
| err = testutil.WaitForBlocks(ctx, 5, cosmosChain, polkadotChain) | ||
| s.Require().NoError(err) | ||
|
|
||
| // Verify cosmos user's final "stake" balance | ||
| cosmosUserStakeBal, err := cosmosChain.GetBalance(ctx, cosmosUser.FormattedAddress(), cosmosChain.Config().Denom) | ||
| s.Require().NoError(err) | ||
| s.Require().True(cosmosUserStakeBal.Equal(finalStakeBal)) | ||
|
|
||
| // Verify cosmos user's final "unit" balance | ||
| unitDenomTrace := transfertypes.ParseDenomTrace(transfertypes.GetPrefixedDenom("transfer", "channel-0", "UNIT")) | ||
| cosmosUserUnitBal, err := cosmosChain.GetBalance(ctx, cosmosUser.FormattedAddress(), unitDenomTrace.IBCDenom()) | ||
| s.Require().NoError(err) | ||
| s.Require().True(cosmosUserUnitBal.Equal(amountUnits)) | ||
|
|
||
| // Verify parachain user's final "unit" balance (will be less than expected due gas costs for stake tx) | ||
| parachainUserUnits, err := polkadotChain.GetIbcBalance(ctx, string(polkadotUser.Address()), 1) | ||
| s.Require().NoError(err) | ||
| s.Require().True(parachainUserUnits.Amount.LTE(math.NewInt(fundAmount)), "parachain user's final unit amount not expected") | ||
|
|
||
| // Verify parachain user's final "stake" balance | ||
| parachainUserStake, err := polkadotChain.GetIbcBalance(ctx, string(polkadotUser.Address()), 2) | ||
| s.Require().NoError(err) | ||
| s.Require().True(parachainUserStake.Amount.Equal(math.NewInt(amountToSend-amountToReflect)), "parachain user's final stake amount not expected") | ||
| }) | ||
| } | ||
|
|
||
| // TestMsgMigrateContract_Success_GrandpaContract features | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit weird that the tag is called timeout :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it is a bit weird, maybe for now we can re-tag this image and give it a better name. Happy if this happened in a follow up though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, i think this should hopefully be fixed once we have a stable relayer image that's not running off just a branch...