Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to build wasm simapp #5286

Merged
merged 7 commits into from
Nov 30, 2023

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Nov 30, 2023

Description

Workflow can be run from main to build the wasm simapp from the specified branch with the specified docker tag.

In the future we can make this automatically build for wasm tags.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label Nov 30, 2023
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick skim looks good

@damiannolan damiannolan added the priority PRs that need prompt reviews label Nov 30, 2023
@chatton chatton enabled auto-merge (squash) November 30, 2023 15:37
@chatton chatton merged commit 6fe8b6c into main Nov 30, 2023
58 checks passed
@chatton chatton deleted the cian/damian/add-build-wasm-simapp-workflow branch November 30, 2023 15:39
damiannolan pushed a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code priority PRs that need prompt reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants