Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS for 08-wasm #5296

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Update CODEOWNERS for 08-wasm #5296

merged 2 commits into from
Dec 4, 2023

Conversation

DimitrisJim
Copy link
Contributor

Description

noticed this during most recent PR, seems like you missed yourself @crodriguezvega 😄

Commit Message / Changelog Entry

chore: add Carlos to codeowners for 08-wasm

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

seems like you missed yourself @crodriguezvega 😄
@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label Dec 1, 2023
@crodriguezvega
Copy link
Contributor

noticed this during most recent PR, seems like you missed yourself @crodriguezvega 😄

That was on purpose 😄 But all right, I'll accept the honour. ❤️

@DimitrisJim DimitrisJim merged commit ffc3c83 into main Dec 4, 2023
58 checks passed
@DimitrisJim DimitrisJim deleted the update-codeowners branch December 4, 2023 10:07
damiannolan pushed a commit that referenced this pull request Dec 5, 2023
seems like you missed yourself @crodriguezvega 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants