Add migration for checksums to collections.KeySet #5324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
damiannolan,
charleenfei,
chatton,
srdtrk and
crodriguezvega
as code owners
DimitrisJim
force-pushed
the
jim/migrate-wasm-store
branch
from
3077be9
to
26e79a9
Compare
damiannolan
approved these changes
Dec 6, 2023
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
colin-axner
approved these changes
Dec 6, 2023
9 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
* wip, we're migrating * add first draft of tests. * Add Logger, log in migrations, use more specific name, handle store errors. * Update modules/light-clients/08-wasm/keeper/migrations.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * Mark key, Checksums msg as deprecated. --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit 2a39b26)
DimitrisJim
added a commit
that referenced
this pull request
Dec 6, 2023
* wip, we're migrating * add first draft of tests. * Add Logger, log in migrations, use more specific name, handle store errors. * Update modules/light-clients/08-wasm/keeper/migrations.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * Mark key, Checksums msg as deprecated. --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit 2a39b26) Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.