Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GetSigners for mock message. #5334

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Remove GetSigners for mock message. #5334

merged 1 commit into from
Dec 7, 2023

Conversation

DimitrisJim
Copy link
Contributor

Description

was misssed.

closes: #XXXX

Commit Message / Changelog Entry

chore: rm GetSigners for mock sdk message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@DimitrisJim DimitrisJim enabled auto-merge (squash) December 7, 2023 10:54
@DimitrisJim DimitrisJim merged commit 5146942 into main Dec 7, 2023
60 checks passed
@DimitrisJim DimitrisJim deleted the jim/rm-getsigners branch December 7, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants