Remove sdk.MustSortJSON from channel types Acknowledgement #5377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expertdicer
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
colin-axner
reviewed
Dec 12, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5377 +/- ##
=======================================
Coverage 80.10% 80.10%
=======================================
Files 189 189
Lines 13147 13147
=======================================
Hits 10532 10532
Misses 2202 2202
Partials 413 413
|
|
boop re syncing branch @expertdicer 😄 |
chatton
approved these changes
Dec 20, 2023
crodriguezvega
approved these changes
Dec 21, 2023
|
@expertdicer can you rebase with main? It would actually also be very useful if you could give us write permissions to your fork, so that we can push updates to your PRs. Thanks! |
I have already invited you guys to my fork. You might need to accept the invitation. TYSM |
Ouch, sorry I had missed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #3920
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.