Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proto message for pruning acks, msgs, stubs for keeper/msg-server. #5409

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

DimitrisJim
Copy link
Contributor

@DimitrisJim DimitrisJim commented Dec 14, 2023

Description

closes: #5410

Commit Message / Changelog Entry

feat: add proto message for pruning acks, 

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@DimitrisJim DimitrisJim added channel-upgradability Channel upgradability feature priority PRs that need prompt reviews labels Dec 14, 2023
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

proto/ibc/core/channel/v1/tx.proto Outdated Show resolved Hide resolved
modules/core/04-channel/types/msgs_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting up these changes. Really easy to review! LGTM!!

proto/ibc/core/channel/v1/tx.proto Outdated Show resolved Hide resolved
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 🚀

I'm totally on board with limit as the naming choice!

modules/core/04-channel/types/errors.go Outdated Show resolved Hide resolved
modules/core/04-channel/types/msgs_test.go Outdated Show resolved Hide resolved
DimitrisJim and others added 3 commits December 14, 2023 20:23
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
@DimitrisJim DimitrisJim merged commit 1ccb724 into 04-channel-upgrades Dec 14, 2023
55 checks passed
@DimitrisJim DimitrisJim deleted the jim/prune-acks-proto-msg-stubs branch December 14, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel-upgradability Channel upgradability feature priority PRs that need prompt reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants