imp: add not allowed keys to error message of authorization #5417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
crodriguezvega
commented
Dec 14, 2023
Comment on lines
-179
to
-181
| if len(jsonObject) > len(allowedPacketDataList) { | ||
| return errorsmod.Wrapf(ErrInvalidAuthorization, "packet contains more packet data keys than packet allow list has") | ||
| } |
There was a problem hiding this comment.
I removed this because I thought it would not add much value if the error doesn't tell the user what keys are not allowed.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5417 +/- ##
==========================================
+ Coverage 80.08% 80.11% +0.02%
==========================================
Files 189 189
Lines 13142 13145 +3
==========================================
+ Hits 10525 10531 +6
+ Misses 2203 2201 -2
+ Partials 414 413 -1
|
damiannolan
approved these changes
Dec 18, 2023
DimitrisJim
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up #5280. It adds the list of not allowed keys to the error.
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.