fix migration log #5497
Merged
fix migration log #5497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5497 +/- ##
=======================================
Coverage 80.88% 80.88%
=======================================
Files 197 197
Lines 15221 15221
=======================================
Hits 12312 12312
Misses 2437 2437
Partials 472 472
|
|
@crodriguezvega Could we backport this to the v8 release line? |
Sure thing. We have a patch release for v8.2.x coming out soon, would that work for you? |
That is perfect! Also happy to use v8.3.x if that's easier? |
I think v8.2.1 will come out earlier, but we will back port to both branches. |
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
* fix migration log * Update migrations.go --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> (cherry picked from commit 7c2996a)
9 tasks
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
* fix migration log * Update migrations.go --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> (cherry picked from commit 7c2996a)
9 tasks
crodriguezvega
pushed a commit
that referenced
this pull request
Apr 22, 2024
crodriguezvega
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.