refactor: use timeout type when possible #5572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
added
the
type: code hygiene
colin-axner
requested review from
AdityaSripal and
damiannolan
as code owners
DimitrisJim
approved these changes
Jan 10, 2024
…bc-go into colin/3483-timeout-type-cleanup
9 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5572 +/- ##
==========================================
- Coverage 81.20% 81.18% -0.03%
==========================================
Files 197 197
Lines 15268 15247 -21
==========================================
- Hits 12399 12378 -21
Misses 2404 2404
Partials 465 465
|
charleenfei
approved these changes
Jan 11, 2024
damiannolan
approved these changes
Jan 11, 2024
|
Added backport label, I'm assuming we want it! |
mergify bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
* refactor: use timeout type when possible * review: consistent error type usage * nit: error wording --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit de8eb6e)
damiannolan
pushed a commit
that referenced
this pull request
Jan 11, 2024
* refactor: use timeout type when possible * review: consistent error type usage * nit: error wording --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit de8eb6e) Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #5404
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.