Add testing for client events #5686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2024
chatton
requested review from
colin-axner,
AdityaSripal,
damiannolan,
crodriguezvega,
charleenfei and
DimitrisJim
as code owners
damiannolan
approved these changes
Jan 24, 2024
colin-axner
reviewed
Jan 24, 2024
testing/events.go
Outdated
| // containsAttribute returns true if the given key/value pair is contained in the given attributes. | ||
| // NOTE: this ignores the indexed field, which can be set or unset depending on how the events are retrieved. | ||
| func containsAttribute(attrs []abci.EventAttribute, key, value string) bool { | ||
| for _, attr := range attrs { |
There was a problem hiding this comment.
a slices.ContainsFn() can be used on these?
There was a problem hiding this comment.
nice suggestion we can use
return slices.ContainsFunc(attrs, func(attr abci.EventAttribute) bool {
return attr.Key == key && attr.Value == value
})
colin-axner
approved these changes
Jan 24, 2024
| suite.SetupTest() | ||
| path := ibctesting.NewPath(suite.chainA, suite.chainB) | ||
|
|
||
| path.EndpointA.Counterparty.Chain.NextBlock() |
There was a problem hiding this comment.
this line might not be necessary anymore
There was a problem hiding this comment.
looks like the test fails without this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge after #5682
Ref #2823
I had to do some refactoring of the
AssertEventsfunction. The changes ensure that it is possible to pass eitherres.Eventsorctx.EventManager().Events().ToABCIEvents()as expected events.I opted to add some event testing into existing tests as they have quite an elaborate set up, and it decided it would be cleaner to just add additional assertions into those tests.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.