Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp: remove unexpected behaviour error string #5702

Merged
merged 2 commits into from
Jan 24, 2024
Merged

imp: remove unexpected behaviour error string #5702

merged 2 commits into from
Jan 24, 2024

Conversation

colin-axner
Copy link
Contributor

Description

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@colin-axner colin-axner added audit Feedback from implementation audit priority PRs that need prompt reviews labels Jan 24, 2024
DimitrisJim
DimitrisJim approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

short & sweet, thanks for being on top of inline docs!

@colin-axner colin-axner enabled auto-merge (squash) January 24, 2024 12:32
@colin-axner colin-axner merged commit 6896814 into main Jan 24, 2024
60 of 62 checks passed
@colin-axner colin-axner deleted the colin/update-error-string branch January 24, 2024 12:37
mergify bot pushed a commit that referenced this pull request Jan 24, 2024
@colin-axner @mergify
imp: modify error string to reflect actual behaviour in receive packe…
71a7c93 
…t defensive check (#5702)

(cherry picked from commit 6896814)
@mergify mergify bot mentioned this pull request Jan 24, 2024
Merged
DimitrisJim pushed a commit that referenced this pull request Jan 24, 2024
@mergify @colin-axner @damiannolan
imp: modify error string to reflect actual behaviour in receive packe…
64897d9 
…t defensive check (#5702) (#5707)

(cherry picked from commit 6896814)

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damiannolan damiannolan damiannolan approved these changes

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@chatton chatton Awaiting requested review from chatton chatton is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

Assignees
No one assigned
Labels
audit Feedback from implementation audit priority PRs that need prompt reviews
Projects
ibc-go
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colin-axner @damiannolan @DimitrisJim