Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Addtional check against wrapped upgrade error in ChannelUpgradeTry #5823

Merged
merged 10 commits into from
Mar 4, 2024

Conversation

hoangdv2429
Copy link
Contributor

Description

closes: #5737

This PR add addtional check in ChannelUpgradeTry incase err is wrapped to avoid panic.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.61%. Comparing base (1c0c756) to head (f4ddb31).
Report is 47 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5823      +/-   ##
==========================================
+ Coverage   81.59%   81.61%   +0.02%     
==========================================
  Files         199      198       -1     
  Lines       15167    12113    -3054     
==========================================
- Hits        12375     9886    -2489     
+ Misses       2326     1765     -561     
+ Partials      466      462       -4     
Files Coverage Δ
modules/core/keeper/msg_server.go 67.45% <100.00%> (+1.38%) ⬆️

... and 171 files with indirect coverage changes

@hoangdv2429 hoangdv2429 marked this pull request as ready for review February 8, 2024 12:34
@hoangdv2429 hoangdv2429 changed the title Addtional check Chore: Addtional check against wrapped upgrade error leading to panic in ChannelUpgradeTry Feb 8, 2024
@hoangdv2429
Copy link
Contributor Author

hoangdv2429 commented Feb 8, 2024

I think the fail test is coming from suite.go:87: test panicked: pulling container image ghcr.io/misko9/hyperspace:20231122v39: Error response from daemon: unauthorized docker img

@hoangdv2429 hoangdv2429 changed the title Chore: Addtional check against wrapped upgrade error leading to panic in ChannelUpgradeTry Chore: Addtional check against wrapped upgrade error in ChannelUpgradeTry Feb 8, 2024
@DimitrisJim
Copy link
Contributor

I think the fail test is coming from suite.go:87: test panicked: pulling container image ghcr.io/misko9/hyperspace:20231122v39: Error response from daemon: unauthorized docker img

should be a flake, dont worry about it! let me re-launch them! 🚀

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me; thanks, @hoangdv2429.

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean solution! Thank you @hoangdv2429 🚀 ❤️‍🔥

@damiannolan damiannolan enabled auto-merge (squash) March 4, 2024 14:42
@damiannolan damiannolan merged commit c489ee4 into cosmos:main Mar 4, 2024
67 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

protect against wrapped upgrade error leading to panic
5 participants