Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation on default accept list in stargate wasm querier #5921

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Mar 4, 2024

Description

Adding docs for default accept list in stargate wasm querier.

Let me know if this needs to be replicated in any versioned docs. I thought not at the moment.

closes: #5846


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @damiannolan!

Let me know if this needs to be replicated in any versioned docs. I thought not at the moment.

Correct, no need!

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@srdtrk srdtrk merged commit 3e42db3 into main Mar 5, 2024
23 checks passed
@srdtrk srdtrk deleted the damian/5846-doc-default-querier-wasm branch March 5, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document addition of VerifyMembership rpc and default accepted queries
5 participants