diff test patch #412
Merged
diff test patch #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙏 🙏 Looks great and makes sense |
danwt
added a commit
that referenced
this pull request
Nov 1, 2022
* wip * diff test patch (#412) Patch Co-authored-by: Daniel <danwtisdall@gmail.com> * add back setter * comment * remove compute consumer unbonding * Update params.go Co-authored-by: Daniel T <30197399+danwt@users.noreply.github.com> Co-authored-by: Daniel <danwtisdall@gmail.com>
danwt
pushed a commit
that referenced
this pull request
Nov 1, 2022
commit cfc4569 Author: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com> Date: Tue Nov 1 08:10:52 2022 -0700 Remove unneeded const variables (#418) * wip * diff test patch (#412) Patch Co-authored-by: Daniel <danwtisdall@gmail.com> * add back setter * comment * remove compute consumer unbonding * Update params.go Co-authored-by: Daniel T <30197399+danwt@users.noreply.github.com> Co-authored-by: Daniel <danwtisdall@gmail.com> commit 602b7ed Author: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com> Date: Fri Oct 28 08:34:26 2022 -0700 Consumer Unbonding As Param (#410) Co-authored-by: Daniel T <30197399+danwt@users.noreply.github.com> Co-authored-by: Daniel <danwtisdall@gmail.com>
danwt
pushed a commit
that referenced
this pull request
Nov 2, 2022
commit 80b751c Author: Marius Poke <marius.poke@posteo.de> Date: Tue Nov 1 20:39:30 2022 +0100 Channel initialization timeout (#406) * add provider-based timeout params * add InitTimeoutTimestamp to store * add init timeout logic * params boilerplate code & making tests pass * add TestInitTimeout* e2e tests * improve e2e tests; add test case to TestUndelegationDuringInit * remove VSC timeout * remove VSC timeout param * add testcase to TestValidateParams * handle StopConsumerChain error & gofmt * Fix init timeout conflicts (#409) * Importable e2e tests (#401) * fixes * add comment to GetInitTimeoutTimestamp * Update proto/interchain_security/ccv/provider/v1/provider.proto Co-authored-by: Aditya <adityasripal@gmail.com> * fix formatting in proto file * add comment to SetConsumerChain * fix typo * add comment re. EndBlock order * change name of testcase in TestUndelegationDuringInit Co-authored-by: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com> Co-authored-by: Aditya <adityasripal@gmail.com> commit cfc4569 Author: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com> Date: Tue Nov 1 08:10:52 2022 -0700 Remove unneeded const variables (#418) * wip * diff test patch (#412) Patch Co-authored-by: Daniel <danwtisdall@gmail.com> * add back setter * comment * remove compute consumer unbonding * Update params.go Co-authored-by: Daniel T <30197399+danwt@users.noreply.github.com> Co-authored-by: Daniel <danwtisdall@gmail.com> commit 602b7ed Author: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com> Date: Fri Oct 28 08:34:26 2022 -0700 Consumer Unbonding As Param (#410) Co-authored-by: Daniel T <30197399+danwt@users.noreply.github.com> Co-authored-by: Daniel <danwtisdall@gmail.com>
danwt
pushed a commit
that referenced
this pull request
Nov 2, 2022
commit ce24844 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 14:59:23 2022 +0000 Bump design.md commit 8d465a9 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 14:51:33 2022 +0000 Adds query.pb.go comment commit aa57bff Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 14:49:12 2022 +0000 revert whitespace commit 2ecc545 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 14:36:52 2022 +0000 improve design.md commit dd5193b Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 14:13:32 2022 +0000 Start improving design and api docs commit bbc5424 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 13:42:11 2022 +0000 Improve comment in relay commit 87e5a9b Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 13:42:05 2022 +0000 Remove comments in module commit 6eef58a Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 13:42:00 2022 +0000 Remove comment in codec commit bf2211b Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 13:27:26 2022 +0000 Impl UnpackInterfaces commit ebc0290 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 13:24:40 2022 +0000 Adds docstrings to keys.go commit 8cdcef6 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 13:24:26 2022 +0000 Adjust hardcoded string path in msg.go commit 4869820 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 13:16:05 2022 +0000 Bump num traces in in mem test commit 76ebbfd Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 13:15:53 2022 +0000 Move code block in core_test commit 2496dfc Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 13:15:45 2022 +0000 Better comment for internal computation commit b95de07 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 13:15:34 2022 +0000 TODO in msg_server commit 92af9f5 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 13:15:27 2022 +0000 Improve relay helper clarity commit 47bc20d Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 13:15:19 2022 +0000 Adjust query.proto commit 05da157 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 13:02:09 2022 +0000 Fix proposal TODO commit ed10448 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 12:57:30 2022 +0000 rename key assignment files with underscore commit 31f0288 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 12:55:11 2022 +0000 Revert "Try remove +100 in _test" This reverts commit 62c0f32. commit 62c0f32 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 12:54:49 2022 +0000 Try remove +100 in _test commit a1fbf82 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 12:53:40 2022 +0000 Move spec to docs, rename docs commit 708089a Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 12:47:19 2022 +0000 Make a naming improvement pass commit 4bf4d84 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 12:41:53 2022 +0000 Update keys.go names commit 4730a8c Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 12:37:32 2022 +0000 fmt keyassignment.go commit efdee98 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 12:35:19 2022 +0000 Renames km -> ka in test commit 1c9db11 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 12:22:13 2022 +0000 Squashed commit of the following: commit 80b751c Author: Marius Poke <marius.poke@posteo.de> Date: Tue Nov 1 20:39:30 2022 +0100 Channel initialization timeout (#406) * add provider-based timeout params * add InitTimeoutTimestamp to store * add init timeout logic * params boilerplate code & making tests pass * add TestInitTimeout* e2e tests * improve e2e tests; add test case to TestUndelegationDuringInit * remove VSC timeout * remove VSC timeout param * add testcase to TestValidateParams * handle StopConsumerChain error & gofmt * Fix init timeout conflicts (#409) * Importable e2e tests (#401) * fixes * add comment to GetInitTimeoutTimestamp * Update proto/interchain_security/ccv/provider/v1/provider.proto Co-authored-by: Aditya <adityasripal@gmail.com> * fix formatting in proto file * add comment to SetConsumerChain * fix typo * add comment re. EndBlock order * change name of testcase in TestUndelegationDuringInit Co-authored-by: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com> Co-authored-by: Aditya <adityasripal@gmail.com> commit cfc4569 Author: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com> Date: Tue Nov 1 08:10:52 2022 -0700 Remove unneeded const variables (#418) * wip * diff test patch (#412) Patch Co-authored-by: Daniel <danwtisdall@gmail.com> * add back setter * comment * remove compute consumer unbonding * Update params.go Co-authored-by: Daniel T <30197399+danwt@users.noreply.github.com> Co-authored-by: Daniel <danwtisdall@gmail.com> commit 602b7ed Author: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com> Date: Fri Oct 28 08:34:26 2022 -0700 Consumer Unbonding As Param (#410) Co-authored-by: Daniel T <30197399+danwt@users.noreply.github.com> Co-authored-by: Daniel <danwtisdall@gmail.com> commit eb501ca Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 12:12:53 2022 +0000 Fix build errors commit 8affd7b Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 12:06:21 2022 +0000 Renam store methods commit eaf08cd Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 11:52:56 2022 +0000 Bring go.mod back to matching main commit 2df5458 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 11:43:49 2022 +0000 Fix core_test comment commit 2c8b3c4 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 11:42:34 2022 +0000 Mass rename to clear up tailing 'pings' commit 888ec23 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 11:41:30 2022 +0000 Fix method handles in core_test commit cad0821 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 11:40:53 2022 +0000 Rename method handle in keyassignment commit c1239d9 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 11:39:22 2022 +0000 Remove long todo commit 17d216a Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 11:38:33 2022 +0000 Rename map words to assignment words commit 360ec22 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 11:22:27 2022 +0000 mass rename keyMap -> keyAssignment commit 1540f5a Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 11:19:04 2022 +0000 RN docs commit 24d4ea3 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 11:16:05 2022 +0000 rename imports in keyassignment_test.go commit 62ed143 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 11:15:33 2022 +0000 Update key assignment imports commit 881077e Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 11:14:13 2022 +0000 Fix build errors due to proto rebuild commit 87869c5 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 11:07:42 2022 +0000 DEL keymap.pb.go commit a1c47bf Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 11:06:40 2022 +0000 Rename and rebuild proto commit 747bef4 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 11:01:49 2022 +0000 rename keymap.proto to keyassignment.proto commit c504f45 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 11:01:24 2022 +0000 rename files prefixed with keymap with keyassignment prefix commit 2410cf7 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 10:59:47 2022 +0000 Mass rename keymap -> keyassignment commit 2daab1e Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 10:59:07 2022 +0000 Mass rename KeyMap -> KeyAssignment commit d7f8d44 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 10:30:28 2022 +0000 Revert import name change in grpc query commit 6b4fc4b Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 10:27:53 2022 +0000 Reach milestone in factoring out test keys commit 80cb85a Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 10:08:34 2022 +0000 Simplify keymap_test (did not run test) commit fbd056b Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 10:08:19 2022 +0000 Simplify grpc_query_test commit 959dc45 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 09:50:54 2022 +0000 Improve import names commit f56196a Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 09:46:22 2022 +0000 Slight improvement core_test keyAssignment commit 89ddbac Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 09:43:24 2022 +0000 Factor out messy validator creation code in diff core setup commit f4ac5b4 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 09:32:15 2022 +0000 Add staking validator helper to test validator commit 0a73df1 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 09:32:00 2022 +0000 Refactor TestDesignateConsensusKeyForConsumerChain handler test commit f0cb3f1 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 09:20:55 2022 +0000 rename import in core_test commit b3c793a Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 09:19:59 2022 +0000 Try revert useless diffs in helpers commit 2708a47 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 09:18:20 2022 +0000 Fix method name in setup commit fdc95bd Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 09:16:36 2022 +0000 (test-diff pass) refactor diff core to use common test val utils commit f1cfae5 Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 09:00:10 2022 +0000 Make adjustment in core_test commit 983c87c Author: Daniel <danwtisdall@gmail.com> Date: Wed Nov 2 08:59:58 2022 +0000 Start factoring out duplicate test keys commit 97abb29 Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 20:08:50 2022 +0000 Leave note for consumerPower commit bdb995f Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 19:31:35 2022 +0000 (make test-diff pass) DELETE find.py debug helper commit b71fc9d Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 19:29:05 2022 +0000 Strip down debug statements commit e344959 Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 19:15:53 2022 +0000 Remove core test grey code commit 899f6ca Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 19:09:44 2022 +0000 (make test-diff pass) refactors commit 944ee5a Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 19:05:39 2022 +0000 Pre strip debugs commit 18b255d Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 19:01:19 2022 +0000 Partial refactors of driver commit b8019ac Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 18:43:08 2022 +0000 Checkpoint pre refactor driver commit c72cd64 Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 18:37:12 2022 +0000 Tweak model generate new traces commit c75a588 Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 18:33:13 2022 +0000 Add key assignment struct commit 42c2593 Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 18:31:22 2022 +0000 Improve model clarity commit bb9f65b Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 18:25:31 2022 +0000 Partial refactor some model parts commit a686ee3 Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 18:14:04 2022 +0000 Rename vscidToMapping commit 48bbdfe Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 18:03:09 2022 +0000 Squashed commit of the following: commit cfc4569 Author: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com> Date: Tue Nov 1 08:10:52 2022 -0700 Remove unneeded const variables (#418) * wip * diff test patch (#412) Patch Co-authored-by: Daniel <danwtisdall@gmail.com> * add back setter * comment * remove compute consumer unbonding * Update params.go Co-authored-by: Daniel T <30197399+danwt@users.noreply.github.com> Co-authored-by: Daniel <danwtisdall@gmail.com> commit 602b7ed Author: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com> Date: Fri Oct 28 08:34:26 2022 -0700 Consumer Unbonding As Param (#410) Co-authored-by: Daniel T <30197399+danwt@users.noreply.github.com> Co-authored-by: Daniel <danwtisdall@gmail.com> commit 8227d0e Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 17:59:29 2022 +0000 Make build commit a88e916 Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 16:29:10 2022 +0000 Regen proto (no build) commit 91bdabf Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 16:23:43 2022 +0000 Adds query commit ddce810 Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 16:00:40 2022 +0000 Trying to debug lost CachedValue commit 6957163 Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 14:28:40 2022 +0000 Impl failing query test commit 6ebc077 Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 13:52:33 2022 +0000 Checkpoint unfinished queries commit b6d2c8c Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 13:30:57 2022 +0000 Start working on query test commit f27923b Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 13:20:26 2022 +0000 Add error commit a05c6ab Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 13:20:22 2022 +0000 Impl grpc query handler commit 6c7b6a0 Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 13:20:07 2022 +0000 Impl cli query logic commit 8e6e978 Author: Daniel <danwtisdall@gmail.com> Date: Tue Nov 1 13:19:56 2022 +0000 Change query proto and compile commit 5c6be16 Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 20:13:17 2022 +0000 API model tweaks commit 6012965 Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 20:13:12 2022 +0000 Del unused fun commit 59e81fc Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 19:16:53 2022 +0000 Caps constant names commit 9481d3d Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 19:12:59 2022 +0000 Comment model commit f57c6d0 Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 19:08:01 2022 +0000 checkpoint commit 94a7036 Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 18:57:10 2022 +0000 Checkpoint commit 37fab45 Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 18:04:57 2022 +0000 cp commit 5dd8293 Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 17:45:34 2022 +0000 Adds todo commit e691abd Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 17:45:28 2022 +0000 Work on model commit e693ec4 Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 16:24:58 2022 +0000 cp commit 3f3e546 Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 16:22:40 2022 +0000 Start working on spec commit 2c42f87 Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 15:56:41 2022 +0000 Impl tx, flags commit 2e055c3 Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 15:45:02 2022 +0000 del unfinished tx_test.go commit 5574ded Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 15:40:16 2022 +0000 save tx_test before delete commit 16a7870 Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 15:37:02 2022 +0000 Start adding tx commit acec85d Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 15:29:38 2022 +0000 Delete unused tx var init commit 967050b Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 15:13:52 2022 +0000 Comments commit 109d2e8 Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 15:11:39 2022 +0000 Adds some tests commit 8727c14 Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 15:07:20 2022 +0000 cp commit e6cd49a Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 14:51:15 2022 +0000 Simplify hander_test commit c4f8937 Author: Daniel <danwtisdall@gmail.com> Date: Mon Oct 31 14:42:56 2022 +0000 Fix key types to create a happy path test commit 7ea1a77 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 20:58:58 2022 +0100 Adds TX handler test skeleton commit f86122f Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 18:04:32 2022 +0100 Return error in tx body if semantic fail commit ecc9260 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 18:02:15 2022 +0100 Implement DesignateConsensusKeyForConsumerChain body commit 5d2dec9 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 18:02:03 2022 +0100 Write New, ValidateBasic for Msg commit a7e935a Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 18:01:50 2022 +0100 Adds to codec.go commit d00b337 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 18:01:41 2022 +0100 Change designation msg proto commit a605b24 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 18:01:27 2022 +0100 Adds errors commit 9cf39d1 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 17:00:22 2022 +0100 Add handler boilerplat commit 99f07ad Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 16:56:54 2022 +0100 Start adding handler test commit fe3a591 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 16:35:48 2022 +0100 Renames tx func call commit 617d7c4 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 15:08:51 2022 +0100 Register Route() and RegisterServices() (use pointer deref) commit 2ddb304 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 15:08:34 2022 +0100 Fix missing line in handler.go commit d23a709 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 15:08:27 2022 +0100 strip down cli/flags, tx commit b6e0335 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 15:08:17 2022 +0100 Adds msg.go commit e035271 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 14:41:16 2022 +0100 Working on handler, msg server commit b72acdd Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 14:41:03 2022 +0100 tx proto change but dont rebuild commit f888208 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 13:46:00 2022 +0100 Adds tx, flags in provider/cli mimicking staking/tx commit 63d0742 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 13:19:04 2022 +0100 Add empty query handler commit 48532e0 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 13:12:23 2022 +0100 Add provider cli query commit 7b02a94 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 13:12:16 2022 +0100 Build query and tx proto go types commit 14a0ec4 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 13:12:00 2022 +0100 Define proto query and tx commit 1cfe0d6 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 09:05:01 2022 +0100 (diff tests pass (with no downtime slashes)) milestone commit 3d0bb51 Author: Daniel <danwtisdall@gmail.com> Date: Fri Oct 28 09:00:04 2022 +0100 (Original diff test traces still pass) commit 187fe36 Author: Daniel <danwtisdall@gmail.com> Date: Thu Oct 27 12:35:22 2022 +0100 cp commit b8fb229 Author: Daniel <danwtisdall@gmail.com> Date: Thu Oct 27 09:26:17 2022 +0100 fix regression commit 0ae42ed Author: Daniel <danwtisdall@gmail.com> Date: Thu Oct 27 09:22:58 2022 +0100 cp commit d2f971d Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 21:13:56 2022 +0100 Add notes, need to add private key signers for diff test commit 27b9ca6 Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 20:28:32 2022 +0100 (diff pass) use <val, vscid> metadata in consumer slash test Metadata is used to do a consumer initiated slash test, by looking up the consumer cons addr. The map has not yet been dynamically changed. commit 39ca796 Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 20:21:41 2022 +0100 Del consumerGreatestVscID commit b841f6c Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 20:21:29 2022 +0100 Pre del consumerGreatestVscID commit 34c52d9 Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 19:50:28 2022 +0100 cp commit 1604f4f Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 18:54:32 2022 +0100 Checkpoint debug commit 49e579d Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 16:47:01 2022 +0100 Confirm build commit bfc1ba9 Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 16:36:29 2022 +0100 remove unbonded slash event from constants.ts commit fb3619d Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 16:36:08 2022 +0100 Pre move key gen test util commit d4bd59c Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 16:26:19 2022 +0100 Adds hacky infra to diff test key mapping commit 682fe1f Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 16:03:48 2022 +0100 Start working on diff test (unfinished) confirm all pass commit 9cf0596 Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 14:02:39 2022 +0100 Reduce overapproximation for model consumer slashing commit 80380f0 Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 12:50:52 2022 +0100 (go test ./... passes) fix string type commit e44381a Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 12:43:22 2022 +0100 Rollback extra diff commit 6ed4d3c Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 12:41:47 2022 +0100 Small refactor commit eaac67b Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 12:39:31 2022 +0100 Remove faulty line in genesis commit 9607c62 Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 12:39:24 2022 +0100 Remove unused alias in keeper commit fa666e4 Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 12:36:18 2022 +0100 Reduce diff in types change commit 347bea3 Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 12:34:21 2022 +0100 del dummy excal commit 780d218 Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 12:12:17 2022 +0100 Adds a validator removal unit test commit 55ce4d3 Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 12:02:41 2022 +0100 Implement provider delete commit b984717 Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 11:52:40 2022 +0100 Tweak proto field name, fix build issues commit 9ac39fa Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 11:45:47 2022 +0100 Make keymap_test build but untested commit f53ae04 Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 11:41:39 2022 +0100 pre change keymap test mapping struct tyep commit 15fb975 Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 11:40:42 2022 +0100 Change keymap commit ddb7582 Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 11:40:38 2022 +0100 change proto names commit d6dd825 Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 11:36:26 2022 +0100 Rebuild proto start manual renaming commit a96bfbc Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 11:26:14 2022 +0100 Start changing to use pca for key commit 0de5df5 Author: Daniel <danwtisdall@gmail.com> Date: Wed Oct 26 11:21:19 2022 +0100 Pre use provider cons addr as forward direction key commit 61a8d0f Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 21:57:12 2022 +0100 Adds pk template commit 4830e7e Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 21:23:04 2022 +0100 Implement consumer removal commit 8ef0e58 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 20:20:28 2022 +0100 Slight refactor tests pass commit 40c3e69 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 19:41:09 2022 +0100 Revert "Start refactoring" This reverts commit a411131. commit 8db1288 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 19:40:52 2022 +0100 Start refactoring commit 1aa33aa Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 19:26:06 2022 +0100 Split main ComputeUpdates commit 86a872a Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 19:18:38 2022 +0100 pre refactor inner commit 48ce93a Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 19:15:34 2022 +0100 all tests (go test ./...) pass commit a4f9765 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 19:09:07 2022 +0100 Get,Del,Iter method renames commit 231d934 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 19:07:13 2022 +0100 rename setter commit 9e6c82e Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 19:04:40 2022 +0100 Del unused store methods commit 4ab1956 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 19:01:27 2022 +0100 Simplify internals internal tests pass commit 0755b73 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 18:45:58 2022 +0100 Recompile proto, all builds commit 7f52e59 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 18:37:34 2022 +0100 build keymap_*.go commit c4a87e2 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 18:32:56 2022 +0100 wip commit 8b40bae Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 18:25:22 2022 +0100 wip commit 4582966 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 18:21:50 2022 +0100 WIP commit 4f8506f Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 16:11:40 2022 +0100 (diff, short) tests pass, fix genesis test commit 56a88bb Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 15:52:06 2022 +0100 Adds chainID param in proposal_test commit b54de67 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 15:47:10 2022 +0100 Proposal, builds commit 8c1f7d9 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 15:44:15 2022 +0100 Changes provider relay commit 4648ff1 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 15:43:19 2022 +0100 Change consumer type commit ccbfe18 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 15:42:05 2022 +0100 Compile proto, fix build errs commit 5ffe108 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 15:35:40 2022 +0100 Adds genesis proto import commit f90c942 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 15:35:33 2022 +0100 Change keeper, keeper_test commit af05cc7 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 15:35:08 2022 +0100 Adds driver find.py commit 7cc13c0 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 15:09:15 2022 +0100 Add genesis changes commit d46bcfb Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 15:07:17 2022 +0100 Add change to difftest/setup commit 57b50a7 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 15:07:12 2022 +0100 Start adding keymap_*.go commit 31ac0f5 Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 15:07:06 2022 +0100 Start adding proto commit db04c2d Author: Daniel <danwtisdall@gmail.com> Date: Tue Oct 25 15:07:00 2022 +0100 Start addings docs
ThanhNhann
pushed a commit
to decentrio/interchain-security
that referenced
this pull request
Jan 3, 2024
* migrate ibc-account module to ibc-go * Add @seantking to CODEOWNERS for interchain accounts module * rename ibc-account -> interchain-accounts (cosmos#280) * rename ibc-account -> interchain-accounts * fix codeowner file * Integrate ICA into testing package, add simple keeper tests (cosmos#282) * add ica to simapp * add simple keeper tests * Add interchain account OnChanOpenInit and InitInterchainAccount tests (cosmos#287) * add OnChanOpenInit test * add InitInterchainAccount test * Update modules/apps/27-interchain-accounts/keeper/relay.go * feat: ica proto (cosmos#305) * feat: adding proto files for interchain accounts & updating references of IBCAccount -> InterchainAccount * doc: updating comments * docs: update comment * fix: updating proto yaml, query name, query params, comments * ICA OnChanOpenTry update + tests (cosmos#299) * update OnChanOpenTry to match ICS specs * write OnChanOpenTry and OnChanOpenAck tests * update comment * test: adding test for OnChanOpenConfirm (cosmos#312) * fix: updating port-id & fixing OnChanOpenInit bug (cosmos#321) * fix: updating port-id & fixing OnChanOpenInit bug * Update modules/apps/27-interchain-accounts/keeper/handshake.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Add counterparty port ID to controller portID (cosmos#319) * refactor! move GeneratePortID to types, add counterpartyConnection sequence change all PortId -> PortID move GeneratePortID to types package add counterparty connection sequence argument utilize connectiontypes connectionID parsing function * refactor! use counterparty portID in interchain account address gRPC Remove existing args from gRPC request for interchain account address Use counterparty portID * tests add generate port id tests * apply self-review fixes * test: check active channel is correct (cosmos#324) * test: check active channel is correct * test: adding version string check * Removed memkey from ICA keeper (cosmos#342) * Removed memkey from ICA keeper * Removed memkey arg in call to NewKeeper from simapp * moving stateless GenerateAddress func to types (cosmos#352) * update ica branch codeowners (cosmos#353) * move Get/SetInterchainAccount to keeper.go, add tests (cosmos#355) * moving setter/getter funcs to keeper.go, adding tests * removing redundant var * fixing test assertion string typo * updating Get/SetInterchainAccount func signatures, tests and adding godocs * grouping imports according, updating suite.FailNow() -> suite.Require().NoError() Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * chore: interchain accounts cleanup, cli alias (cosmos#362) * adding ica alias for interchain-accounts queries * refactoring bind port and claim capability functionality, code cleanup and godocs * updating interchain accounts pkg naming (cosmos#364) * adding ica grpc query tests (cosmos#368) * updating grpc query tests, removing queryClient on KeeperTestSuite (cosmos#379) * ICA: Adding tests for relay.go (cosmos#337) * test: adding test for TrySendTx * test: adding tests for data check * test: adding check for SendTx with []sdk.Message * chore: seperate imports * test: add helper function for creating ICA path * test: adding cases for incorrect outgoing data & channel does not exist * Update ICA on main + add app version negotiation stub (cosmos#403) * Bump github.com/cosmos/cosmos-sdk from 0.43.0-rc1 to 0.43.0-rc2 (cosmos#269) Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.43.0-rc1 to 0.43.0-rc2. - [Release notes](https://github.com/cosmos/cosmos-sdk/releases) - [Changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.43.0-rc2/CHANGELOG.md) - [Commits](cosmos/cosmos-sdk@v0.43.0-rc1...v0.43.0-rc2) --- updated-dependencies: - dependency-name: github.com/cosmos/cosmos-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * generate swagger files (cosmos#267) * Reject Redundant Tx Antedecorator (cosmos#235) * writeup simple antedecorator * only do antehandler on checkTx * Update modules/core/04-channel/ante.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * enable 2 antehandler strategies, and write tests * remove strict decorator and pass on non-packet/update type * move ante logic into its own package * changelog Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * perform a no-op on redundant relay messages (cosmos#268) * create initial changes for delivertx handling * handle closed channel no-ops, fix tests * self review nits * add changelog * add events for no op messages * add back comment * Bump codecov/codecov-action from 1.5.2 to 2.0.1 (cosmos#273) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 1.5.2 to 2.0.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v1.5.2...v2.0.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * remove ChanCloseInit function from transfer keeper (cosmos#275) * remove CloseChanInit from transfer * add changelog Co-authored-by: Aditya <adityasripal@gmail.com> * Bump codecov/codecov-action from 2.0.1 to 2.0.2 (cosmos#296) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 2.0.1 to 2.0.2. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v2.0.1...v2.0.2) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/spf13/cast from 1.3.1 to 1.4.0 (cosmos#301) Bumps [github.com/spf13/cast](https://github.com/spf13/cast) from 1.3.1 to 1.4.0. - [Release notes](https://github.com/spf13/cast/releases) - [Commits](spf13/cast@v1.3.1...v1.4.0) --- updated-dependencies: - dependency-name: github.com/spf13/cast dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump technote-space/get-diff-action from 4.2 to 5 (cosmos#306) Bumps [technote-space/get-diff-action](https://github.com/technote-space/get-diff-action) from 4.2 to 5. - [Release notes](https://github.com/technote-space/get-diff-action/releases) - [Changelog](https://github.com/technote-space/get-diff-action/blob/main/.releasegarc) - [Commits](technote-space/get-diff-action@v4.2...v5) --- updated-dependencies: - dependency-name: technote-space/get-diff-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * bump to SDK v0.43.0-rc3 (cosmos#308) * SDK v0.43.0-rc3 * add capability fixes * add @seantking as codeowner to interchain accounts (cosmos#309) * Bump google.golang.org/grpc from 1.39.0 to 1.39.1 (cosmos#320) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.39.0 to 1.39.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.39.0...v1.39.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/cosmos/cosmos-sdk from 0.43.0-rc3 to 0.43.0 (cosmos#325) Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.43.0-rc3 to 0.43.0. - [Release notes](https://github.com/cosmos/cosmos-sdk/releases) - [Changelog](https://github.com/cosmos/cosmos-sdk/blob/master/CHANGELOG.md) - [Commits](cosmos/cosmos-sdk@v0.43.0-rc3...v0.43.0) --- updated-dependencies: - dependency-name: github.com/cosmos/cosmos-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * module: improve 04-channel logging (cosmos#323) * module: improve 04-channel logging * update log Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * update changelog (cosmos#326) * Bump google.golang.org/grpc from 1.39.1 to 1.40.0 (cosmos#332) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.39.1 to 1.40.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.39.1...v1.40.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/spf13/cast from 1.4.0 to 1.4.1 (cosmos#338) Bumps [github.com/spf13/cast](https://github.com/spf13/cast) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/spf13/cast/releases) - [Commits](spf13/cast@v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: github.com/spf13/cast dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/tendermint/tendermint from 0.34.11 to 0.34.12 (cosmos#341) Bumps [github.com/tendermint/tendermint](https://github.com/tendermint/tendermint) from 0.34.11 to 0.34.12. - [Release notes](https://github.com/tendermint/tendermint/releases) - [Changelog](https://github.com/tendermint/tendermint/blob/master/CHANGELOG.md) - [Commits](tendermint/tendermint@v0.34.11...v0.34.12) --- updated-dependencies: - dependency-name: github.com/tendermint/tendermint dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * fix broken links in integration.md (cosmos#340) * fix broken link in integration.md * fix: broken link to simulator.md file in cosmos-sdk docs Co-authored-by: Carlos Rodriguez <crodveg@gmail.com> * Created helper functions for emitting packet events (cosmos#343) * Created helper functions for emitting packet events * Fixed comments and re-ordered helper functions Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Merge pull request from GHSA-qrhq-96mh-q8jv * Bump codecov/codecov-action from 2.0.2 to 2.0.3 (cosmos#346) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 2.0.2 to 2.0.3. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v2.0.2...v2.0.3) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Bump actions/setup-go from 2.1.3 to 2.1.4 (cosmos#349) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2.1.3 to 2.1.4. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v2.1.3...v2.1.4) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * increase port identifier limit to 128 characters (cosmos#344) * increase port identifier limit to 128 characters increase port limit and add tests for port validation * add changelog * fix tests * update codeowners to include new team members and granular ownership (cosmos#354) * update codeowners * add proto files to ownership * bump SDK dependency (cosmos#367) * update SDK dependency and fix changes Removes tests from sdk_test.go which are no longer needed to upstream changes in the SDK Fixes client_test.go due to inclusion of the fee in tx events * bump SDK version to v0.44.0 * adding client status cli query (cosmos#372) * adding client status cli query * adding query client status cli to changelog * updating long CLI help usage * adding markdown link checker to ci workflows (cosmos#377) * packet acknowledgment filtering (cosmos#375) * adding packet commitments to QueryPacketAcknowledgementsRequest for filtering * adding testcase for filtered packet ack query * adding changelog entry for packet ack filtering * updating packet sequences type to repeated uint64 * updating to query specific packet acks outside bounds of paginated req * updating changelog field naming, removing redundant pagination in query test * continue in favour of returning an error on query PacketAcknowledgements * updating to return empty array of acks if none of the provided commitments are found Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Bump github.com/tendermint/tendermint from 0.34.12 to 0.34.13 (cosmos#386) Bumps [github.com/tendermint/tendermint](https://github.com/tendermint/tendermint) from 0.34.12 to 0.34.13. - [Release notes](https://github.com/tendermint/tendermint/releases) - [Changelog](https://github.com/tendermint/tendermint/blob/v0.34.13/CHANGELOG.md) - [Commits](tendermint/tendermint@v0.34.12...v0.34.13) --- updated-dependencies: - dependency-name: github.com/tendermint/tendermint dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Change ICS 20 packet data amount to be string (cosmos#350) * modify proto defintions * fix non string usage in code and various tests * fix mbt tests * fix bug in data validation * fix various build issues fix unaddressed issues from changing amount from uint64 to string * add changelog entry * apply review suggestions Add check that amount is strictly positive Construct granular error messages to indicate invalid amount value or failure to parse amount * verify and fix telemetry bug Verify msg panics on amounts > int64 by adding tests Add checks to telemetry emission of transfer amounts to handle when the amount cannot be casted to float32 * fix: ibc build docs (cosmos#361) * initial fix commit * add release v1.0.1 to versions * improvements for docs website * add new version * address review comments Co-authored-by: Carlos Rodriguez <crodveg@gmail.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * feat: scalable version queries (cosmos#384) * adding protos for port query interface * adding NegotiateAppVersion method to IBCModule interface * adding grpc port query implementation and module surrounds * adding NegotiateAppVersion implementation to apps/transfer and mocks * updating ErrInvalidVersion error code * adding grpc query tests for 05-port * updating grpc naming, adding godocs, removing redundant query cli * updating grpc query tests * adding changelog entry for cosmos#384 app version negotiation * fixing error formatting in transfer version negotiation Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * removing client/cli query * updating grpc query naming, adding new fields and associated surrounds Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Bump codecov/codecov-action from 2.0.3 to 2.1.0 (cosmos#399) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 2.0.3 to 2.1.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v2.0.3...v2.1.0) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: adding fn stub for version negotiation Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Aditya <adityasripal@gmail.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <crodveg@yahoo.es> Co-authored-by: Carlos Rodriguez <crodveg@gmail.com> Co-authored-by: Luke Rhoads <51463884+lukerhoads@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Charly <charly@interchain.berlin> * fix err message (cosmos#419) * feat: ica app version negotiation (cosmos#410) * adding NegotiateAppVersion implementation and tests * updating GenerateAddress to return sdk.AccAddress, fixing tests * updating ica handshake flow to parse address from version string, fixing associated tests * updating module_tests * derive ica addresses from module account addr * removing unused keys * adding improved version validation, updating tests * removing redundant local var - owner * updating Delimiter godoc * updating validation logic * adding test cases for ValidateVersion * adding additional validation testcase, updating godocs * updating Version -> VersionPrefix, error msgs, validation tests * updating NewAppVersion func sig and usage * updating NewAppVersion args and returning more appropriate errors for handshake * Update modules/apps/27-interchain-accounts/keeper/handshake.go Co-authored-by: Sean King <seantking@users.noreply.github.com> * updating ValidateVersion godoc Co-authored-by: Sean King <seantking@users.noreply.github.com> * test: adding tests for OnRecvPacket (cosmos#412) * test: adding tests for OnRecvPacket * test: adding further test cases for onRecvPacket * chore: merge latest main to interchain-accounts (cosmos#435) * chore: update ica prefix for port identifiers (cosmos#434) * removing ICAPrefix const in favour of VersionPrefix * updating tests * test: account/keeper tests for ICA (cosmos#420) * test: adding tests for account type * tests: adding test for keeper & account * fix: updating channel closing capabilities * fix: updating to use test library instead of hardcoded values * fix: updating error handling for account * test: adding test for account string comparison * fix: updating marshal yaml * feat: module account address derivation (cosmos#428) * adding module account to interchain-accounts with associated changes * configuring ica module account in simapp * Update modules/apps/27-interchain-accounts/keeper/keeper.go Co-authored-by: Sean King <seantking@users.noreply.github.com> * updating godoc and import alias Co-authored-by: Sean King <seantking@users.noreply.github.com> * ICA: tests for module.go (cosmos#424) * test * test: adding module.go test with handshake callback tests * tests: adding key tests * additional code cov and clean up (cosmos#440) * split ica module.go into ibc_module.go (cosmos#453) Splits IBCModule logic into separate ibc_module.go file and updates app.go registration * Rename IBCAccountPacketData, Remove TxRaw (cosmos#456) * rename IBCAccountPacketData, remove txRaw type * Update proto/ibc/applications/interchain_accounts/v1/types.proto * Rename DeserializeTx, enforce []sdk.Msg usage in SerializeCosmosTx (cosmos#457) * rename DeserializeTx to DeserializeCosmosTx, simply serialization logic * improve godoc wording * remove computeVirtualTxHash (cosmos#473) * chore: ctrl port connection id validation (cosmos#454) * adding pipe char | to identifier regex * updating GeneratePortID to use pipe delimiter in favour of dash, ParseAddressFromVersion to use Split in favour of TrimPrefix * adding CounterpartyHops method to expected channel keeper interface * updating tests to satisy delimiter updates * adding connection seq validation of ctrl port id and updating tests * cleanup * adding defensive check for ParseAddressFromVersion * adding conn sequence parsing funcs to pkg types * moving conn sequence validation to reusable func * updating error msgs, adding tests for conn seq parsers * adding expected sequence to error msgs * updating ParseCtrlConnSequence to ParseControllerConnSequence * fixing counterparty port error * Update modules/apps/27-interchain-accounts/keeper/handshake.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Update modules/apps/27-interchain-accounts/keeper/handshake.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Update modules/apps/27-interchain-accounts/types/account.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * removing pipe from valid identifier regex * adding error returns to parsing funcs, updating tests, error messages * separting imports in keys.go * updating handshake tests * Update modules/apps/27-interchain-accounts/types/keys.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * renaming validation func, removing parenthesis in error msgs * renaming func validateControllerPort -> validateControllerPortParams Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * chore: correctly set/delete active channels (cosmos#463) * correctly set active channels, implement delete OnChanCloseConfirm callback * removing active channel on packet timeout * remove ica hooks (cosmos#480) * chore: minor nits - renaming and error msgs (cosmos#464) * update ErrPortAlreadyBound error string - remove for address * rename RegisterInterchainAccount api portID -> counterpartyPortID * wrap claim capability errors in handshake * Update modules/apps/27-interchain-accounts/keeper/account.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * adding channel and port id in error msg * correcting error wording Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * chore: update portkey to include port ID (cosmos#467) * update port key to use prefix, separate key prefixes to vars * updating godoc * Update modules/apps/27-interchain-accounts/keeper/keeper.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * adding todo with ica genesis issue ref * fixing failing test from browser commit * removing GetPort in favour of GetAllPorts Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * ICA: Rename TxBody, Remove serialization logic from controller, introduce CosmosTx type (cosmos#474) * remove ICA TxBody type, use repeated Any in packet data * adjust SerializeCosmosTx, fix tests * apply self nits * add memo length validation * chore(spec): remove old specification * ica: unspecified type enum for interchain account packet data (cosmos#487) * adding unspecified type enum, adding defensive check to ValidateBasic * Update modules/apps/27-interchain-accounts/types/packet_test.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * chore: ica audit nitpicks (cosmos#483) * updating version validation with corrections * removing unused methods from expected keeper interfaces * updating validate version error msg * update to use ErrInvalidVersion in favour of ErrInvalidAccountAddress * fixed typo (cosmos#507) * ica: move Serialize/DeserializeCosmosTx to package types (cosmos#493) * moving SerializeCosmosTx and DeserializeCosmosTx to types pkg * removing dead code * adding mockSdkMsg message type for failing codec test scenarios * Update modules/apps/27-interchain-accounts/types/codec_test.go * ica: TrySendTx error handling nits (cosmos#491) * updating error handling and msgs for TrySendTx flow * renaming active channel ID getter/setters, adding comment re indeterminate errs * renaming DeleteActiveChannel -> DeleteActiveChannelID * chore: adding damo to codeowners (cosmos#520) * ica: AuthenticateTx/executeTx clean up (cosmos#490) * cleaning up AuthenticateTx and executeTx to reduce unnecessary complexity * adding error wrapping to AuthenticateTx * updating err msg to include expected signer * ICA Controller Side Middleware (cosmos#417) * initial draft for ica middleware * add capability handling, fix build and tests * split module.go into ibc_module.go * add middleware handshake tests * fix app.go wiring and various tests * godoc self nits * remove unnecessary error * update comment * fix testing build * split channel keeper interface splits ChannelKeeper interface into ics4Wrapper and core ChannelKeeper * fix tests * remove comments * add callback for timeouts * Apply suggestions from code review Co-authored-by: Sean King <seantking@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> * fix test and update testing README apply test fix pointed out by Sean. Update testing README to reflect how to test with the mock module for middleware * add OnRecvPacket test Add test cases for OnRecvPacket, reused structure in relay_test.go * add failing test case for NegotiateAppVersion Co-authored-by: Sean King <seantking@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> * ica: genesis state implementation (cosmos#481) * initial genesis state draft * updating protos * including yaml tags, sorting proto file structure * updating to use range queries for active channels/interchain accounts * updating GetAllPorts test * moving test strings to expected vars * test: relay tests for TrySendTx/OnRecvPacket (cosmos#531) * adding various sdk.Msg type tests and cleaning up relay_test.go * cleaning up tests to make consistent * adding missing godoc for OnRecvPacket * adding ica test for transfertypes.MsgTranfer * updating hardcoded strings to use sdk.DefaultBondDenom * Update modules/apps/27-interchain-accounts/keeper/relay_test.go Co-authored-by: Sean King <seantking@users.noreply.github.com> * removing staking test for insufficient funds Co-authored-by: Sean King <seantking@users.noreply.github.com> * ICA controller/host submodules (cosmos#541) * go mod tidy * creating new genesis types for controller and host submodules * removing dead root module code * updating genesis helpers and adding newly generated types * adding interchain-accounts controller submodule * adding interchain-accounts host submodule * updating simapp to include controller and host ica submodules * adding errors returns for disallowed handshake directions, removing embedded app from host module, updating simapp to conform * updating simapp to remove nil arg to ica host ibc module * removing ics4Wrapper arg from ica host submodule * cleaning up module.go for controller and host submodules * removing commented out tests * commit with broken tests to rebase * disabling app version negotation on controller submodule * fixing tests - now passing * various cleanup, godocs and moving code * updating error msgs to conform to pkg split * removing commented out code * adding combined ica genesis, consolidating to single ica AppModule, updating app.go * adding missing godocs * clean up, godocs, rename validate.go -> version.go, move version related funcs * updating godocs and code organization * removing controller module acc, using icatypes module name for module acc in host submodule * correcting panic error msg * Update modules/apps/27-interchain-accounts/controller/ibc_module.go * Update modules/apps/27-interchain-accounts/types/genesis.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * updating logger kvs, and simplifying OnRecvPacket * address nits on error strings and godocs Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * chore: ica submodules minor improvements and cleanup * test: adding test for RegisterInterchainAccount & adding check to rel… (cosmos#552) * test: adding test for RegisterInterchainAccount & adding check to relay_test * Update modules/apps/27-interchain-accounts/host/keeper/relay_test.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * Update modules/apps/27-interchain-accounts/host/keeper/relay_test.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * Update modules/apps/27-interchain-accounts/host/keeper/account_test.go * Update modules/apps/27-interchain-accounts/host/keeper/account_test.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * ICA Code Hygiene (cosmos#553) * chore: re-creating account.go for controller side for consitency * chore: remove comment * Update modules/apps/27-interchain-accounts/controller/keeper/account.go * ica: wrong handshake flow tests (cosmos#538) * add tests for testing wrong handshake flow Adds tests for each handshake test attempting to initialize the handshake using the wrong flow. Adds an additional portID check to OnChanOpenAck. * remove unnecessary comment * readjust tests based on new layout * Add tests provided by Damian * add tests for OnChanCloseInit and OnChanCloseConfirm on host side * add OnChanCloseInit/Confirm and NegotiateAppVersion tests to controller side * fix failing test * ica: genesis state validation (cosmos#554) * adding genesis state validation * adding genesis state validation tests * Update modules/apps/27-interchain-accounts/types/genesis_test.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Update modules/apps/27-interchain-accounts/types/genesis_test.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * adding ValidateAccountAddress helper to reduce code duplication Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Rename imports within host/controller (cosmos#571) * alias ica types import to for host submodule * alias ica types import to for controller submodule * Add Enable/Disable controller/host on-chain params (cosmos#566) * add ica params Add new Params type to ICA. A single test is added to check defaults and validation. Usage within the ICA keepers is still needed * regenerate params proto into host and controller submodules * split params implementation into host/controller * add keeper params logic * Apply suggestions from code review Co-authored-by: Damian Nolan <damiannolan@gmail.com> * add host genesis init/export params test case * add genesis validation for controller and host params Co-authored-by: Damian Nolan <damiannolan@gmail.com> * Disable usage of controller and host submodules based on on-chain params (cosmos#575) * add usage of enabling/disabling controller and host submodules Adds if statement checks in controller/host ibc_module.go. Adds tests for each added if statements. Tests not added for controller ack/timeout since tests do not exist for those functions yet. * Update modules/apps/27-interchain-accounts/controller/ibc_module_test.go * add grpc query for controller and host params (cosmos#574) Adds gRPC routes for controller params and host params. Add tests and registers the gRPC gateways on the ica module * modify ica portid to be interchain-account instead of ibcaccount (cosmos#577) * feat: allowlist host param using msg typeURLs (cosmos#576) * add ica params Add new Params type to ICA. A single test is added to check defaults and validation. Usage within the ICA keepers is still needed * regenerate params proto into host and controller submodules * split params implementation into host/controller * add keeper params logic * Apply suggestions from code review Co-authored-by: Damian Nolan <damiannolan@gmail.com> * add host genesis init/export params test case * updating host proto params to include msg allowlist * adding surrounds for new allowlist host param * enforcing msg is present in allowlist in AuthenticateTx, updating tests * regenerating protos post merge conflict * applying suggestinons from review * adding strings.Trimspace as suggested Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com> * Add cli query for host and controller params (cosmos#578) * add cli query commands for host/controller params * Update modules/apps/27-interchain-accounts/client/cli/cli.go * Update modules/apps/27-interchain-accounts/controller/client/cli/query.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * Update modules/apps/27-interchain-accounts/host/client/cli/query.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> * renmaing ModuleName to SubModuleName for ica controller/host (cosmos#579) Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * add tests/code coverage for OnRecv, OnTimeout and OnAck for controller submodule (cosmos#585) Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Luke Rhoads <51463884+lukerhoads@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aditya <adityasripal@gmail.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <crodveg@yahoo.es> Co-authored-by: Carlos Rodriguez <crodveg@gmail.com> Co-authored-by: Charly <charly@interchain.berlin>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@smarshall-spitzbart this should address the issue