Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add override flag for client reuse #487

Merged
merged 4 commits into from
Apr 15, 2021
Merged

Add override flag for client reuse #487

merged 4 commits into from
Apr 15, 2021

Conversation

akhilkumarpilli
Copy link
Contributor

closes: #445

@akhilkumarpilli akhilkumarpilli marked this pull request as ready for review April 8, 2021 10:14
colin-axner
colin-axner approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, going forward if we need to add more client configuration, this should be added to the config file and obtained from the chain as opposed to using flags and stacking the function arguments.

Override probably makes sense to be a flag though

relayer/client.go Outdated
// Check if an identical light client already exists
clientID, found := FindMatchingClient(c, dst, clientState)
if !found {
clientID, found := "", false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
clientID, found := "", false
var (
clientID string
found bool
)

You might want to commit these changes yourself since they probably aren't gofmt'd

@colin-axner colin-axner merged commit 492378a into master Apr 15, 2021
@colin-axner colin-axner deleted the akhil/add-override-flag branch April 15, 2021 10:05
@colin-axner colin-axner mentioned this pull request Aug 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@fedekunze fedekunze Awaiting requested review from fedekunze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add override flag for client reuse
2 participants
@akhilkumarpilli @colin-axner