-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(headless,atomic): add type "module" to atomic, atomic-react and headless #4442
Open
louis-bompart
wants to merge
15
commits into
master
Choose a base branch
from
type=module
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+452
−351
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4c3d793 - Browse repository at this point
Copy the full SHA 4c3d793View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8896adb - Browse repository at this point
Copy the full SHA 8896adbView commit details
Commits on Sep 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d4f9150 - Browse repository at this point
Copy the full SHA d4f9150View commit details -
Configuration menu - View commit details
-
Copy full SHA for d65b94c - Browse repository at this point
Copy the full SHA d65b94cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad2e6f8 - Browse repository at this point
Copy the full SHA ad2e6f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbae835 - Browse repository at this point
Copy the full SHA bbae835View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6264b8 - Browse repository at this point
Copy the full SHA c6264b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d232fd - Browse repository at this point
Copy the full SHA 8d232fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 062e6e7 - Browse repository at this point
Copy the full SHA 062e6e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d8345d - Browse repository at this point
Copy the full SHA 6d8345dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c48774 - Browse repository at this point
Copy the full SHA 4c48774View commit details -
Update packages/atomic/.storybook/main.mts
Co-authored-by: Alex Prudhomme <78121423+alexprudhomme@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 38f7b3a - Browse repository at this point
Copy the full SHA 38f7b3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2de421 - Browse repository at this point
Copy the full SHA b2de421View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2207b51 - Browse repository at this point
Copy the full SHA 2207b51View commit details -
All errors are fixed. Warnings left that I cant fix : 1. The types errors for commonJS are not urgent 2. I can't find how to tell stencil to generate commonjs files as .cjs instead of .js ``` npx publint ./node_modules/@coveo/atomic-react @coveo/atomic-react lint results: Warnings: 1. pkg.exports["."].types types is interpreted as ESM when resolving with the "require" condition. This causes the types to only work when dynamically importing the package, even though the package exports CJS. Consider splitting out two "types" conditions for "import" and "require", and use the .cts extension, e.g. pkg.exports["."].require.types: "./dist/index.d.cts" npx publint ./node_modules/@coveo/atomic @coveo/atomic lint results: Warnings: 1. pkg.main is dist/index.cjs.js and is written in CJS, but is interpreted as ESM. Consider using the .cjs extension, e.g. dist/index.cjs.cjs 3. pkg.exports["."].require is ./dist/index.cjs.js and is written in CJS, but is interpreted as ESM. Consider using the .cjs extension, e.g. ./dist/index.cjs.cjs 4. pkg.exports["."].types types is interpreted as ESM when resolving with the "require" condition. This causes the types to only work when dynamically importing the package, even though the package exports CJS. Consider splitting out two "types" conditions for "import" and "require", and use the .cts extension, e.g. pkg.exports["."].require.types: "./dist/types/index.d.cts" 5. pkg.exports["./loader"].import is ./loader/index.js and is written in ESM, but is interpreted as CJS. Consider using the .mjs extension, e.g. ./loader/index.mjs npx publint ./node_modules/@coveo/headless @coveo/headless lint results: Warnings: 1. pkg.exports["."].types types is interpreted as ESM when resolving with the "require" condition. This causes the types to only work when dynamically importing the package, even though the package exports CJS. Consider splitting out two "types" conditions for "import" and "require", and use the .cts extension, e.g. pkg.exports["."].require.types: "./dist/definitions/index.d.cts" ```
Configuration menu - View commit details
-
Copy full SHA for 015040f - Browse repository at this point
Copy the full SHA 015040fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.