Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(headless,atomic): add type "module" to atomic, atomic-react and headless #4442

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Commits on Sep 19, 2024

  1. type module everywhere

    louis-bompart committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4c3d793 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8896adb View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. lint&ut

    louis-bompart committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    d4f9150 View commit details
    Browse the repository at this point in the history
  2. e2e should be fine

    louis-bompart committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    d65b94c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ad2e6f8 View commit details
    Browse the repository at this point in the history
  4. fix typedoc

    louis-bompart committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    bbae835 View commit details
    Browse the repository at this point in the history
  5. deps

    louis-bompart committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c6264b8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8d232fd View commit details
    Browse the repository at this point in the history
  7. missing patch

    louis-bompart committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    062e6e7 View commit details
    Browse the repository at this point in the history
  8. tweak-cypresses

    louis-bompart committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6d8345d View commit details
    Browse the repository at this point in the history
  9. fixlint

    louis-bompart committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4c48774 View commit details
    Browse the repository at this point in the history
  10. Update packages/atomic/.storybook/main.mts

    Co-authored-by: Alex Prudhomme <78121423+alexprudhomme@users.noreply.github.com>
    louis-bompart and alexprudhomme committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    38f7b3a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b2de421 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    2207b51 View commit details
    Browse the repository at this point in the history
  13. fix errors (#4444)

    All errors are fixed.
    
    Warnings left that I cant fix : 
    1. The types errors for commonJS are not urgent
    2. I can't find how to tell stencil to generate commonjs files as .cjs
    instead of .js
    
    ```
     npx publint ./node_modules/@coveo/atomic-react
    @coveo/atomic-react lint results:
    Warnings:
    1. pkg.exports["."].types types is interpreted as ESM when resolving with the "require" condition. This causes the types to only work when dynamically importing the package, even though the package exports CJS. Consider splitting out two "types" conditions for "import" and "require", and use the .cts extension, e.g. pkg.exports["."].require.types: "./dist/index.d.cts"
    
    
     npx publint ./node_modules/@coveo/atomic
    @coveo/atomic lint results:
    Warnings:
    1. pkg.main is dist/index.cjs.js and is written in CJS, but is interpreted as ESM. Consider using the .cjs extension, e.g. dist/index.cjs.cjs
    3. pkg.exports["."].require is ./dist/index.cjs.js and is written in CJS, but is interpreted as ESM. Consider using the .cjs extension, e.g. ./dist/index.cjs.cjs
    4. pkg.exports["."].types types is interpreted as ESM when resolving with the "require" condition. This causes the types to only work when dynamically importing the package, even though the package exports CJS. Consider splitting out two "types" conditions for "import" and "require", and use the .cts extension, e.g. pkg.exports["."].require.types: "./dist/types/index.d.cts"
    5. pkg.exports["./loader"].import is ./loader/index.js and is written in ESM, but is interpreted as CJS. Consider using the .mjs extension, e.g. ./loader/index.mjs
    
    
    npx publint ./node_modules/@coveo/headless
    @coveo/headless lint results:
    Warnings:
    1. pkg.exports["."].types types is interpreted as ESM when resolving with the "require" condition. This causes the types to only work when dynamically importing the package, even though the package exports CJS. Consider splitting out two "types" conditions for "import" and "require", and use the .cts extension, e.g. pkg.exports["."].require.types: "./dist/definitions/index.d.cts"
    ```
    alexprudhomme committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    015040f View commit details
    Browse the repository at this point in the history