Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(headless): fix internal resolution errors in node16 #4445

Open
wants to merge 14 commits into
base: type=module
Choose a base branch
from

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Sep 20, 2024

Publint status

  • atomic : no errors
  • headless: no errors
  • atomic-react: no errors

Are the types wrong status

  • atomic : errors Internal resolution in node16 (Do we need to address this ? People don't use atomic with typescript anyway ?) + cjs type warnings
  • headless: cjs type warnings
  • atomic-react: cjs type warnings

Comment on lines -7 to +9
"module": "ES2022",
"module": "Node16",
"target": "ES2022",
"moduleResolution": "Bundler",
"moduleResolution": "Node16",
Copy link
Contributor Author

@alexprudhomme alexprudhomme Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only relevant changes in this PR is here. Changing these to Node16 is required for the types to be correctly inferred by typescript. Change this value also causes all relative imports to have a .js extension. More details here https://github.com/arethetypeswrong/arethetypeswrong.github.io/blob/main/docs/problems/InternalResolutionError.md

Copy link

github-actions bot commented Sep 20, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 239.2 239.2 0
commerce 338 338 0
search 407.7 407.7 0
insight 392.7 392.7 0
recommendation 250.1 250.1 0
ssr 401.6 401.6 0
ssr-commerce 350.2 350.2 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Base automatically changed from type=module-patch to type=module September 20, 2024 16:21
@alexprudhomme alexprudhomme changed the title fix headless type defintions chore(headless): fix internal resolution errors in node16 Sep 20, 2024
@alexprudhomme alexprudhomme marked this pull request as ready for review September 20, 2024 16:40
@alexprudhomme alexprudhomme requested review from a team as code owners September 20, 2024 16:40
@alexprudhomme alexprudhomme requested review from fpbrault, louis-bompart and fbeaudoincoveo and removed request for a team September 20, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant