name darkened after being shot + removed icon from sidebar #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaro32768
changed the title
iounpaladin
reviewed
Mar 14, 2024
| @@ -360,7 +360,8 @@ $eloValues: (1500 0.3 1 0.3) (1600 0.3 1 0.5) (1849 0 1 0.7) (1850 1 1 0.7) (190 | |||
| .card-container.flipped { | |||
| transform: rotateY(180deg); | |||
| } | |||
| .player-number.leftgame { | |||
| .player-number.leftgame, | |||
| .player-number.isDead { | |||
There was a problem hiding this comment.
I like the design pattern of different classes for different uses but shouldn't there be a visual distinction of dead and still sitting? Or is this to prevent the metagaming of knowing when someone leaves after being shot?
There was a problem hiding this comment.
Yes, the intent was to prevent meta gaming when someone gets shot and leaves, icon will still show for people not in the lobby. I figured it would be better for people not in a lobby to still see that this player is still in a lobby.
Also, it's been a while so I do not remember if I tested that or not, but it's probably a good idea to test if it still works properly when the player quits the entire site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
After someone gets shot they name gets darkened (same as if they leave) to prevent people getting influenced by dead people leaving. Their icon from right sidebar also gets removed for seated players (people not seated in the game can still see a location of the dead person on the sidebar).
Screenshots
Tested Locally
Tests
Changelog
Changelog Entry (delete this section if this PR does not need a changelog entry)
New Feature
Minor Change
Changelog Headline: Dead players no longer show as present in the lobby.
Changelog Details: Dead players get their name darkened and they get icon removed from sidebar. People not involved in the lobby can still see their icon in the sidebar.