Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEBOX_ADMINS github usernames should be case-insensitive #93

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

brimworks
Copy link

One of our admin users give me their github username, but the API returned their user-name with some capitol letters which made them appear as though they were not administrators.

What did you implement:

Closes #12345 (Github)

Github admin usernames should be case-insensitive.

How did you implement it:

Lower-case the usernames and then do indexOf() to check if the username exists.

How can we verify it:

Set CODEBOX_ADMINS to contain your github username in a case that is different than the canonical casing.

...also the unit test verifies it works.

Todos:

  • [x ] Write tests
  • Write documentation
  • Fix linting errors
  • Tag ready for review or wip

Is this a breaking change?: NO

One of our admin users give me their github username, but the API returned their user-name with some capitol letters which made them appear as though they were not administrators.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant