Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in computing target image spacing #158

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Fix bug in computing target image spacing #158

merged 3 commits into from
Mar 15, 2024

Conversation

HangJung97
Copy link
Member

@HangJung97 HangJung97 commented Mar 15, 2024 •
edited
Loading

What does this PR do?

  • Fix bug in computing target imaging spacing:
    • Error of using argmin instead of argmax to get the lowest resolution axis resulting in wrong target spacing.
  • Fix typing.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@HangJung97 HangJung97 added the bug Something isn't working label Mar 15, 2024
@HangJung97 HangJung97 self-assigned this Mar 15, 2024
@HangJung97 HangJung97 merged commit db92cd5 into main Mar 15, 2024
1 check passed
@HangJung97 HangJung97 deleted the bugfix branch March 15, 2024 18:35
@HangJung97 HangJung97 changed the title Fix bug in computing target imaging spacing Fix bug in computing target image spacing Mar 15, 2024
HangJung97 added a commit that referenced this pull request Mar 15, 2024
@HangJung97
Revert "Fix bug in computing target imaging spacing (#158)"
13c18f7 
This reverts commit db92cd5.
HangJung97 added a commit that referenced this pull request Mar 15, 2024
@HangJung97
Fix bug in computing target image spacing (#158)
e4492bd 
* Fix bug in `_get_target_spacing` during preprocessing + Fix typing

* Add `anisotropy_threshold` argument in preprocessor classes

* Fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@HangJung97 HangJung97

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HangJung97