Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update owslib to 0.19.2 #89

Merged
merged 4 commits into from
Mar 16, 2020
Merged

update owslib to 0.19.2 #89

merged 4 commits into from
Mar 16, 2020

Conversation

davidcaron
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the ci label Mar 13, 2020
@davidcaron
Copy link
Contributor Author

davidcaron commented Mar 13, 2020

@fmigneault any minor version release of weaver planned soon?

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   74.59%   74.59%           
=======================================
  Files          65       65           
  Lines        8888     8888           
  Branches     1138     1138           
=======================================
  Hits         6630     6630           
  Misses       1964     1964           
  Partials      294      294

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da7b41b...e767d06. Read the comment docs.

@fmigneault
Copy link
Collaborator

I was waiting for the package (#78)
Can be udpated soon, but need to fix the requirements.
Python 3.5 fails because owslib dropped it.

@davidcaron
Copy link
Contributor Author

davidcaron commented Mar 16, 2020

If owslib dropped support for python 3.5, you're right that this would mean weaver should too when we update to this version.

As I understood it, I think this PR should fix #78?

@github-actions github-actions bot added the ci/doc Issue related to documentation of the package label Mar 16, 2020
setup.py Show resolved Hide resolved
fmigneault
fmigneault previously approved these changes Mar 16, 2020
Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a line in the changelog about dropping 3.5 and good to merge

@davidcaron davidcaron merged commit 8293318 into master Mar 16, 2020
@davidcaron davidcaron deleted the update-owslib-0.19.2 branch March 16, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants